Fix for building from source (two character modification to setup.py) #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the variable isn't found in the check. The empty value is problematic for distutils, but NCAR's compiler wrappers eliminate the empty space, whereas directly calling the compilers does not - this leads to build problems on other systems. (Usually hidden because it's installed via Conda in most cases.) I'm very bad at python, so my terminology above is likely incorrect, but I'm quite sure the diagnosis is right. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified setup.py's EXTRA_OBJECTS variable to use an empty set ([] vs '') when the variable isn't found in the check. The empty value is problematic for distutils, but NCAR's compiler wrappers eliminate the empty space, whereas directly calling the compilers does not - this leads to build problems on other systems. (Usually hidden because it's installed via Conda in most cases.)
I'm very bad at python, so my terminology above is likely incorrect, but I'm pretty sure the diagnosis is right. :-)