Repository navigation
Conversation
Port of 597020d (from ros-hwinds-sb40-restart-dev33) onto develop 284b19e, so WRF-CFBM can use wind_hinterp_opt=3 with current develop. Conflict resolutions: - namelist_mod: keep develop's fuelmc_g_live in the /fire/ group; the fuelmc_g_lh rename (4f7493d) is not part of this port. - wrfdata_mod: drop the duplicate Get_z0 (develop reads z0 before the wind select); read phl once ahead of the staggered branch. - state_mod: keep develop's Interpolate_vars_atm_to_fire layout (fz0 computed first, Interp_winds2grid for 3D winds) and add the staggered path as a branch inside the 3D-winds case. z0 is not destroyed there because develop destroys it at the end of the routine. Behavior change relative to 597020d: in standalone runs, wind_hinterp_opt only has an effect when set to 3. For options 1 and 2, the 3D winds go through develop's Interp_winds2grid, which uses hinterp_opt. (cherry picked from commit 597020d)
masih-e
force-pushed
the
develop-staggered-winds
branch
from
November 2, 2026 20:21
fcebc44 to
00d4099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds
wind_hinterp_opt = 3, a WRF C-grid stagger-aware horizontal wind interpolation. Instead of interpolating destaggered mass-grid winds, it uses WRF's native U/V placement together with PH/PHB and ZNT, following WRF-Fire more closely. It is available in the WRF-coupled path (Interp_wrfstaggered_winds_to_cfbminio/wrf_mod.F90) and in standalone runs forced by wrfout files that provide staggered U/V, PH, PHB and ZNT (Interp_wrfout_staggered_winds_to_cfbm). The option is valid only withwind_vinterp_opt = 0; the namelist check stops the run otherwise.This is a port of 597020d from
ros-hwinds-sb40-restart-dev33onto currentdevelop(284b19e). The WRF-CFBM branchcfbm-staggered-windscalls these routines and cannot build againstdevelopwithout them.Conflict resolutions against develop:
io/namelist_mod.F90: keeps develop'sfuelmc_g_live. Thefuelmc_g_lhrename (4f7493d) is not part of this PR.io/wrfdata_mod.F90: drops a duplicateGet_z0(develop reads z0 before the wind select); readsphlonce ahead of the staggered branch.state/state_mod.F90: keeps develop'sInterpolate_vars_atm_to_firelayout (fz0 computed first,Interp_winds2gridfor 3D winds) and adds the staggered path as a branch in the 3D-winds case. z0 is still destroyed at the end of the routine, as on develop.Behavior relative to 597020d: in standalone runs,
wind_hinterp_optonly takes effect when set to 3. For options 1 and 2, 3D winds go through develop'sInterp_winds2grid, which useshinterp_opt. The default (wind_hinterp_opt = 2) does not enter the new code path.Type of change
Tests conducted:
Platform: NCAR Derecho. Compiler/libraries: GCC 12.4.0, Cray MPICH 8.1.29, NetCDF 4.9.2, CMake 3.26.6 (ncarenv/24.12).
cfbm-staggered-winds) builds and links against this branch; thewrfexecutable containsInterp_wrfstaggered_winds_to_cfbm.Documentation:
doc/Configuration.rstdocumentswind_vinterp_opt,hinterp_optandwind_hinterp_opt. Note: it describes options 1 and 2 ofwind_hinterp_optas nearest/bilinear mass-grid wind interpolation. That holds for the WRF-coupled path; in standalone runs those two options defer tohinterp_opt(see above). This wording may need adjusting before merge.Contributions:
Maria Frediani developed the original stagger-aware wind interpolation implementation (597020d). Masih Eghdami ported it onto current develop, resolved integration conflicts, and verified standalone and WRF-CFBM builds. Codex assisted with code review and focused numerical checks.