-
Notifications
You must be signed in to change notification settings - Fork 53
ufs-dev PR279 #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ufs-dev PR279 #601
Conversation
3be6b5c to
9137d38
Compare
|
@scrasmussen Please pull in the latest main branch (#600 was merged). |
grantfirl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax error in GFS_typedefs.F90
ebb0642 to
86eb351
Compare
…an option to use liquid potential temperature in local mixing of GFSPBL
86eb351 to
676e4b2
Compare
Mer
@grantfirl is this ok now? I couldn't find the syntax error you referred to and all the RTs are building now so I think it is ok? |
This has been completed 👍 |
hertneky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and builds now (phew, I thought I did something wrong last because I did not catch the letter swap, gj Grant!). All RTs on Ursa were successful
grantfirl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks!
|
Let's hold off on merging until Dom has had a chance to review the ccpp-physics PR. |
|
@scrasmussen NCAR/ccpp-physics#1148 was merged. Please update the ccpp-physics submodule pointer and .gitmodules in preparation for merge. |
676e4b2 to
624d001
Compare
|
Noting that the |
This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch.
Associated ufs/dev PR:
Associated ufs-wm PR:
Associated fv3atm PR:
Associated NCAR PR: