Skip to content

Conversation

@grantfirl
Copy link
Collaborator

@scrasmussen Please pull in the latest main branch (#600 was merged).

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax error in GFS_typedefs.F90

@scrasmussen scrasmussen force-pushed the ufs-dev-pr279 branch 2 times, most recently from ebb0642 to 86eb351 Compare July 9, 2025 19:31
…an option to use liquid potential temperature in local mixing of GFSPBL
@scrasmussen
Copy link
Member Author

@scrasmussen Please pull in the latest main branch (#600 was merged).

Mer

syntax error in GFS_typedefs.F90

@grantfirl is this ok now? I couldn't find the syntax error you referred to and all the RTs are building now so I think it is ok?

@scrasmussen scrasmussen requested a review from grantfirl July 9, 2025 19:53
@scrasmussen
Copy link
Member Author

@scrasmussen Please pull in the latest main branch (#600 was merged).

This has been completed 👍

Copy link
Collaborator

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and builds now (phew, I thought I did something wrong last because I did not catch the letter swap, gj Grant!). All RTs on Ursa were successful

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks!

@grantfirl
Copy link
Collaborator

Let's hold off on merging until Dom has had a chance to review the ccpp-physics PR.

@grantfirl
Copy link
Collaborator

@scrasmussen NCAR/ccpp-physics#1148 was merged. Please update the ccpp-physics submodule pointer and .gitmodules in preparation for merge.

@scrasmussen
Copy link
Member Author

Noting that the build and run SCM regression tests action again broke on the debug version but passed when rerunning it alone. This issue was talked about in today's SCM meeting and is being looked into by @grantfirl. It's being looked into so I'll merge this PR now

@scrasmussen scrasmussen merged commit 5fa3a52 into NCAR:main Jul 16, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants