[main] Followup for #1187 for NOAA models#1205
Conversation
81dd287 to
5b2a656
Compare
5b2a656 to
de3c522
Compare
climbfuji
left a comment
There was a problem hiding this comment.
Looks as expected. Regarding the sending of slices, that would need to be implemented using other MPI functionality than bcast.
Let me note here that there are still schemes that read with all ranks instead of reading with rank zero and broadcasting (e.g. photochemistry). These should be looked at in the future, too.
@climbfuji Agreed. I didn't want to extend the time to get this merged in and clean up some of the other code management tasks that need to happen after this is taken care of. Plus, the sync from NCAR/main to ufs/dev was already pretty large and I wanted to just get this initial capability in as-is before extending it. Added #1210 |
This reverts commit b9db6a9.
This reverts commit a4b88b7.
This reverts commit a4b88b7.
Description of Changes:
These changes allow NOAA models to compile/run with the changes from #1187.
aer_presandaer_inshould be allocated at once so that sending/receiving MPI ranks can effectively broadcast; there may also be an issue with different size slices of the array being broadcast from different ranks.Tests Conducted:
SCM RTs - see NCAR/ccpp-scm#682
UFS RTs - see ufs-community/ufs-weather-model#3190 (tested along with many other accumulated physics changes, but B4B for all tests that actually finished)
Dependencies:
None
Documentation:
None
Issue (optional):
None