Skip to content

[main] Followup for #1187 for NOAA models#1205

Merged
grantfirl merged 3 commits intoNCAR:mainfrom
grantfirl:main-PR1187-followup
Apr 13, 2026
Merged

[main] Followup for #1187 for NOAA models#1205
grantfirl merged 3 commits intoNCAR:mainfrom
grantfirl:main-PR1187-followup

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

@grantfirl grantfirl commented Mar 26, 2026

Description of Changes:

These changes allow NOAA models to compile/run with the changes from #1187.

  • change calls to subroutines in NOAA-specific interstitials to reflect changes in interfaces for the added ccpp_bcast calls
  • remove ccpp_bcast calls from two subroutines in aerinterp.F90 due to hanging UFS RTs; if reinstated in the future, the overloaded ccpp_bcast subroutine will need to add interfaces for 4D and 5D integer arrays, plus the entire arrays of aer_pres and aer_in should be allocated at once so that sending/receiving MPI ranks can effectively broadcast; there may also be an issue with different size slices of the array being broadcast from different ranks.

Tests Conducted:

SCM RTs - see NCAR/ccpp-scm#682
UFS RTs - see ufs-community/ufs-weather-model#3190 (tested along with many other accumulated physics changes, but B4B for all tests that actually finished)

Dependencies:

None

Documentation:

None

Issue (optional):

None

@grantfirl grantfirl force-pushed the main-PR1187-followup branch from 81dd287 to 5b2a656 Compare April 8, 2026 20:12
@grantfirl grantfirl force-pushed the main-PR1187-followup branch from 5b2a656 to de3c522 Compare April 8, 2026 20:13
@grantfirl grantfirl marked this pull request as ready for review April 10, 2026 19:52
@grantfirl grantfirl changed the title Followup for #1187 for NOAA models [main] Followup for #1187 for NOAA models Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as expected. Regarding the sending of slices, that would need to be implemented using other MPI functionality than bcast.

Let me note here that there are still schemes that read with all ranks instead of reading with rank zero and broadcasting (e.g. photochemistry). These should be looked at in the future, too.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

grantfirl commented Apr 10, 2026

Looks as expected. Regarding the sending of slices, that would need to be implemented using other MPI functionality than bcast.

Let me note here that there are still schemes that read with all ranks instead of reading with rank zero and broadcasting (e.g. photochemistry). These should be looked at in the future, too.

@climbfuji Agreed. I didn't want to extend the time to get this merged in and clean up some of the other code management tasks that need to happen after this is taken care of. Plus, the sync from NCAR/main to ufs/dev was already pretty large and I wanted to just get this initial capability in as-is before extending it.

Added #1210

@grantfirl grantfirl merged commit b9db6a9 into NCAR:main Apr 13, 2026
3 checks passed
scrasmussen added a commit to scrasmussen/ccpp-physics that referenced this pull request Apr 14, 2026
scrasmussen added a commit to scrasmussen/ccpp-physics that referenced this pull request Apr 14, 2026
scrasmussen added a commit to scrasmussen/ccpp-physics that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants