-
Notifications
You must be signed in to change notification settings - Fork 165
ufs-community ccpp-physics 307 #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce tuning parameter for convective cloud liquid for GFSv17/GEFSv13/SFSv1
Collaborator
|
@scrasmussen It looks like there are more changes (100) in satmedmfvdifq.F in this PR than the original (82). Could you double-check this? |
grantfirl
approved these changes
Sep 24, 2025
climbfuji
reviewed
Sep 24, 2025
climbfuji
reviewed
Sep 24, 2025
climbfuji
reviewed
Sep 24, 2025
climbfuji
reviewed
Sep 24, 2025
climbfuji
reviewed
Sep 24, 2025
climbfuji
approved these changes
Sep 25, 2025
Collaborator
climbfuji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @grantfirl !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Replaces current integer parameter
icplocn2atmwith logical flaguse_oceanuv.Relates PRs:
Documentation:
See Dependency PRs.
Dependencies
At least the following, maybe the newer ccpp-physics prs.
Issue (optional):
Fixes ufs-community/ufs-weather-model#2704