Ensure short-circuiting in Lam2 available check in mixedlayer_restart_Bodner #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_Bodner Otherwise, associated(Lam2) may be checked before present(Lam2), which may lead to sigsegv.
alperaltuntas
changed the title
mnlevy1981
requested changes
Oct 22, 2025
Collaborator
mnlevy1981
left a comment
mnlevy1981
left a comment
There was a problem hiding this comment.
One minor recommendation, but this looks great.
| logical :: line_is_empty, keep_going | ||
| integer, dimension(2) :: EOSdom ! The i-computational domain for the equation of state | ||
| integer :: i, j, k, is, ie, js, je, Isq, Ieq, Jsq, Jeq, nz | ||
| logical :: lam2_available = .false. |
Collaborator
There was a problem hiding this comment.
I don't see anything about this in the style guide, but if you are going to initialize lam2_available I think you want to do it below rather than in the variable declaration to avoid implicitly save-ing it. Maybe just set it to .false. in the else block for the if (CS%wave_enhanced_ustar) then you modify below?
alperaltuntas
force-pushed
the
fix_lam2_check
branch
from
3dad0bf to
437609b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise,
associated(Lam2)may be checked beforepresent(Lam2), which may lead to sigsegv.This behavior was discovered while testing ESCOMP/MOM_interface#298
Testing: aux_mom.b4b