LF17 fix #375
Merged
LF17 fix #375
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…La_SL if lamult was present
alperaltuntas
approved these changes
Jul 25, 2025
|
Because this PR is changing answers (see the failures with the TC testing regression changes), I am afraid that this bug-fix will require a new bug-fix run-time parameter or a feature parameter. If a bug-fix runtime parameter is used, it might make sense to add this correction after the pending merge from dev/gfdl to main (see mom-ocean#1668) is merged back into dev/ncar so that the new option |
Member
|
@phall-brown Could you try merging the latest dev/ncar branch to see if that resolves the CI regression test failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LF17 parameterization by altering a conditional statement so that surface layer Langmuir number (La_SL) is always calculated (the conditional statement assumed that if the Langmuir multiplier, lamult, was present that La_SL did not need to be calculated, presumably because it would be passed in from the wave component).