Fix outline indices not being updated for GeographicMesh when positio… #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sashavolv2 Thank you for the precise and thoughtful contribution. At the moment, we're unable to accept external pull requests, and we're working to resolve that. We'll leave this pull request open and will address it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes a typo in GeographicMesh that causes outlines to break when positions are updated.
Why Should This Be In Core?
It fixes a bug in a core shape.
Benefits
It fixes a bug.
Potential Drawbacks
None.
Applicable Issues
Outlines break when positions are updated on a GeographicMesh.