-
Notifications
You must be signed in to change notification settings - Fork 14
Data Catalog filters/search #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 31 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
2d1686a
Add filter controls barebones
danielfdsilva 6241313
Fix styles for drop menu icon button
danielfdsilva affaf1b
Add Text Highlight component
danielfdsilva 838976d
Implement draft version of data catalog filters
danielfdsilva dae6794
Remove list view mode
danielfdsilva 166837e
Reposition catalog browse controls
ricardoduplos 23f715a
Refactor control markup and styling
ricardoduplos 399fb81
Add collapsible search input
danielfdsilva 368e455
Add scrollable filters on small screens
danielfdsilva d05e738
Add pills with topics
danielfdsilva 19a0f3f
Add featured discoveries
danielfdsilva 656e3a5
Tweak pill default appearance
ricardoduplos 4eafe9e
Fix grid blowout on card list
danielfdsilva 49fb271
Add topics to dataset cards
danielfdsilva 8113847
Tweak browse controls inner spacing
ricardoduplos 65d2d33
Tweak catalog inner spacing
ricardoduplos 0160723
Resize featured card
ricardoduplos 79fbb6b
Update search field clear button
ricardoduplos 5882294
Add meta information to dataset cards
danielfdsilva 45972dc
Cleanup temporary data
danielfdsilva cb2fe78
Include dataset menu on data catalog page
danielfdsilva 7f1f5e3
Separate notebook connect modal from button
danielfdsilva 53ad725
Add analyse data option to datasets menu
danielfdsilva 1ea16e6
Dataset menu for catalog page (#516)
danielfdsilva 28b4133
Allow for datasets without thematics
danielfdsilva 008b18b
Make search case insensitive
danielfdsilva 533e880
Add clear filter button
danielfdsilva 2d8368c
Scroll to filters on card tag click
danielfdsilva c58531f
Fix pill styles
danielfdsilva 806767a
Use constant for all option
danielfdsilva fbf1247
Memoize prepareDatasets
danielfdsilva a95991e
Import types directly for react and mapbox
danielfdsilva b2836e7
Import mapboxgl map with alias
danielfdsilva bdbe1b4
Fix dataset count line height
danielfdsilva 4651cc8
Remove clear button when there's no search
danielfdsilva 8624306
Show character count message
danielfdsilva 7fababa
Remove type pill from dataset cards
danielfdsilva 37beffd
Make topics searchable
danielfdsilva e88bd14
Import types directly for react and mapbox (#517)
danielfdsilva 2d886d3
Only show featured datasets on featured section
danielfdsilva 12f3184
Merge branch 'main' into feature/data-catalog-search
danielfdsilva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity: do we have a set practice on using React types directly, rather than importing them (
import React, { ReactNode } from 'react';)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we do. Do you favor one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually import everything at the top of a file, so for consistency's sake, I don't see why this should be different for React types (especially in this file where we have 4 occurrences). Very much nitpicking though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nerik Did this in a separate PR because there were a lot of changes. #517