ci: use npx for npm version instead of global installation#1969
Merged
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
@dzole0311 i was waiting to merge the previous PR until I could test that it actually worked, but yesterday GitHub had some major outage and I was just able to run the workflow today to test it and see that it didn't actually worked 😅 So this! |
slesaad
changed the title
Contributor
|
relates to: #1961 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Uses npx for npm version for publishing instead of installing globally which we apparently don't have permission for. See this test workflow run
I've already tested this via the test-trusted-publishing branch - this is the workflow run using
npm publish --dry-run. It only failed because of the following error:But the other steps in the workflow should create a new version.