-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: move parcel dashboard to /apps #1957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
0e6a97e
d4a6b25
660fbc9
8094dba
b695c53
f39d0d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # VEDA Dashboard | ||
| # VEDA Dashboard - Component Library | ||
|
|
||
|  | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # VEDA Dashboard | ||
|
||
|
|
||
|  | ||
|
|
||
| VEDA is a dashboard to explore data. | ||
|
|
||
| This repository contains the UI component of VEDA where development of new features happens. | ||
| If you're looking to add content check the [veda-config](https://github.com/NASA-IMPACT/veda-config) repository. | ||
|
|
||
| ## Content documentation | ||
|
|
||
| **⚠️ The content configuration should not happen on this repository, but on your instance of [veda-config](https://github.com/NASA-IMPACT/veda-config).** | ||
|
|
||
| The following documentation will guide you through the process of configuring the content. | ||
|
|
||
| - Check [CONFIGURATION](../../docs/content/CONFIGURATION.md) to see a list of configuration options for VEDA. | ||
| - Check [CONTENT](../../docs/content/CONTENT.md) for how to structure the content pieces. | ||
| - Check [PAGE_OVERRIDES](../../docs/content/PAGE_OVERRIDES.md) for all the layout overrides available to you and how they work. | ||
|
|
||
|
|
||
| ## Development documentation | ||
|
|
||
| Check the documentation below for how to setup and develop features for `veda-ui`. | ||
|
|
||
| - **Start here**: Check [SETUP.md](../../docs/development/SETUP.md) for instructions on how to set up your local development environment. | ||
| - Check [ARCHITECTURE](../../docs/development/ARCHITECTURE.md) docs to read about architecture. | ||
| - Check [PAGE_OVERRIDES](../../docs/development/PAGE_OVERRIDES.md) for information about the component/content overriding feature. | ||
|
|
||
| ## License | ||
| This project is licensed under **Apache 2**, see the [LICENSE](../../LICENSE) file for more details. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,5 +20,5 @@ The app can then be run by any web server. | |
| If you want to use any other parcel feature it is also possible. Example: | ||
|
|
||
| ``` | ||
| PARCEL_BUNDLE_ANALYZER=true yarn parcel build app/index.html | ||
| PARCEL_BUNDLE_ANALYZER=true yarn parcel build apps/dashboard-parcel/index.html | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment above. wondering if parcel specific concerns shouldn't be in top level documentation if we're expecting to support multiple types of dashboard builds. Otherwise, I think we should provide a comment with that indicates deprecation and a TODO with ticket number. |
||
| ``` | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,7 @@ | |
| "lint:css": "stylelint 'packages/veda-ui/src/styles/**/**' 'packages/veda-ui/src/**/*.(js|ts|tsx|jsx)'", | ||
| "ts-check": "yarn tsc --noEmit --skipLibCheck", | ||
| "test": "TZ=UTC jest", | ||
| "pretest:e2e": "node test/playwright/generateTestData.js", | ||
| "pretest:e2e": "node apps/dashboard-parcel/test/playwright/generateTestData.js", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would be specific to a parcel only build. Wondering if playwright tests can be general to all builds (vite, next, etc) to prevent the need to duplicate tests that should be build neutral? |
||
| "test:e2e": "yarn playwright test", | ||
| "test:e2e:ui": "yarn playwright test --ui", | ||
| "release": "release-it --", | ||
|
|
@@ -41,7 +41,7 @@ | |
| }, | ||
| "targets": { | ||
| "veda-app": { | ||
| "source": "./app/index.html", | ||
| "source": "./apps/dashboard-parcel/index.html", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also specific to a parcel build. Will there be instructions to update this for other builds (vite, next)? |
||
| "context": "browser" | ||
| } | ||
| }, | ||
|
|
@@ -269,7 +269,7 @@ | |
| "$uswds": "~/packages/veda-ui/src/uswds", | ||
| "$libs": "~/packages/veda-ui/src/libs", | ||
| "$graphics": "~/packages/veda-ui/graphics", | ||
| "$test": "~/test", | ||
| "$test": "~/apps/dashboard-parcel/test", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above, can tests be neutral to builds. If not, can this become parcel-test with a notice for deprecation and a TODO with a ticket number. |
||
| "$mock": "~/mock", | ||
| "$static": "~/static" | ||
| }, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.