Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
}
},
{
"files": "test/playwright/**",
"files": "apps/dashboard-parcel/test/playwright/**",
"extends": "plugin:playwright/recommended"
},
{
Expand Down
2 changes: 1 addition & 1 deletion README-lib.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# VEDA Dashboard
# VEDA Dashboard - Component Library

![VEDA logo](./docs/media/nasa-veda-logo-pos.svg)

Expand Down
30 changes: 30 additions & 0 deletions apps/dashboard-parcel/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# VEDA Dashboard
Copy link
Contributor

@ifsimicoded ifsimicoded Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can only parcel specific documentation live in this readme so we're not duplicating readmes.
If we're not planning on persisting parcel, how about just updating the existing readme to reference that parcel will be deprecated and a TODO with ticket number.

Top level docs that reference Parcel which need updates:

  • MDX_BLOCKS.md (references parcel specific url builder new URL)
  • ARCHITECTURE.md (a lot of parcel specific build notes)
  • DEPLOYMENT.md (you updated the path, but this is specific to the parcel build)
  • PAGE_OVERRIDES_DEV.md (developer note on parcel type definitions)
  • SETUP.md (remove link to parcel env var docs)

Also wondering if the parcel specific folders should be moved here from the top level too?

/parcel-resolver...
/parcel-transfomer...
and the automated parcel bundle reports


![VEDA logo](../../docs/media/nasa-veda-logo-pos.svg)

VEDA is a dashboard to explore data.

This repository contains the UI component of VEDA where development of new features happens.
If you're looking to add content check the [veda-config](https://github.com/NASA-IMPACT/veda-config) repository.

## Content documentation

**⚠️ The content configuration should not happen on this repository, but on your instance of [veda-config](https://github.com/NASA-IMPACT/veda-config).**

The following documentation will guide you through the process of configuring the content.

- Check [CONFIGURATION](../../docs/content/CONFIGURATION.md) to see a list of configuration options for VEDA.
- Check [CONTENT](../../docs/content/CONTENT.md) for how to structure the content pieces.
- Check [PAGE_OVERRIDES](../../docs/content/PAGE_OVERRIDES.md) for all the layout overrides available to you and how they work.


## Development documentation

Check the documentation below for how to setup and develop features for `veda-ui`.

- **Start here**: Check [SETUP.md](../../docs/development/SETUP.md) for instructions on how to set up your local development environment.
- Check [ARCHITECTURE](../../docs/development/ARCHITECTURE.md) docs to read about architecture.
- Check [PAGE_OVERRIDES](../../docs/development/PAGE_OVERRIDES.md) for information about the component/content overriding feature.

## License
This project is licensed under **Apache 2**, see the [LICENSE](../../LICENSE) file for more details.
2 changes: 1 addition & 1 deletion app/index.html → apps/dashboard-parcel/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ <h1>{{appTitle}}</h1>
}
</script>

<script type='module' src='../packages/veda-ui/src/main.tsx'></script>
<script type='module' src='../../packages/veda-ui/src/main.tsx'></script>
</body>

</html>
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { test, expect } from '../pages/basePage';

const stories = JSON.parse(
// eslint-disable-next-line @typescript-eslint/no-require-imports
require('fs').readFileSync('test/playwright/playwrightTestData.json', 'utf8')
require('fs').readFileSync('apps/dashboard-parcel/test/playwright/playwrightTestData.json', 'utf8')
)['stories'];

test('load stories on /stories route', async ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { test, expect } from '../pages/basePage';

const stories = JSON.parse(
// eslint-disable-next-line @typescript-eslint/no-require-imports
require('fs').readFileSync('test/playwright/playwrightTestData.json', 'utf8')
require('fs').readFileSync('apps/dashboard-parcel/test/playwright/playwrightTestData.json', 'utf8')
)['stories'];

test.describe('stories card routing', () => {
Expand Down
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docs/development/DEPLOYMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ The app can then be run by any web server.
If you want to use any other parcel feature it is also possible. Example:

```
PARCEL_BUNDLE_ANALYZER=true yarn parcel build app/index.html
PARCEL_BUNDLE_ANALYZER=true yarn parcel build apps/dashboard-parcel/index.html
Copy link
Contributor

@ifsimicoded ifsimicoded Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above. wondering if parcel specific concerns shouldn't be in top level documentation if we're expecting to support multiple types of dashboard builds. Otherwise, I think we should provide a comment with that indicates deprecation and a TODO with ticket number.

```
3 changes: 2 additions & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ function parcelBuildLib(cb) {
// package.json to use. When running this directly from the UI repo (for
// development) we need to actively point parcel to the correct target
// otherwise the site doesn't get built.
const parcelTarget = process.cwd() === __dirname ? ['app/index.html'] : [];
const parcelTarget =
process.cwd() === __dirname ? ['apps/dashboard-parcel/index.html'] : [];

function parcelServe(cb) {
portscanner.findAPortNotInUse(9000, 9999, function (error, port) {
Expand Down
2 changes: 1 addition & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,5 +211,5 @@ module.exports = {
// Whether to use watchman for file crawling
// watchman: true,

modulePathIgnorePatterns: ['/test/playwright/']
modulePathIgnorePatterns: ['/apps/dashboard-parcel/test/playwright/']
};
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"lint:css": "stylelint 'packages/veda-ui/src/styles/**/**' 'packages/veda-ui/src/**/*.(js|ts|tsx|jsx)'",
"ts-check": "yarn tsc --noEmit --skipLibCheck",
"test": "TZ=UTC jest",
"pretest:e2e": "node test/playwright/generateTestData.js",
"pretest:e2e": "node apps/dashboard-parcel/test/playwright/generateTestData.js",
Copy link
Contributor

@ifsimicoded ifsimicoded Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be specific to a parcel only build. Wondering if playwright tests can be general to all builds (vite, next, etc) to prevent the need to duplicate tests that should be build neutral?

"test:e2e": "yarn playwright test",
"test:e2e:ui": "yarn playwright test --ui",
"release": "release-it --",
Expand All @@ -41,7 +41,7 @@
},
"targets": {
"veda-app": {
"source": "./app/index.html",
"source": "./apps/dashboard-parcel/index.html",
Copy link
Contributor

@ifsimicoded ifsimicoded Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also specific to a parcel build. Will there be instructions to update this for other builds (vite, next)?
If not, same as above, I think we should provide a comment that indicates deprecation and a TODO with ticket number.

"context": "browser"
}
},
Expand Down Expand Up @@ -269,7 +269,7 @@
"$uswds": "~/packages/veda-ui/src/uswds",
"$libs": "~/packages/veda-ui/src/libs",
"$graphics": "~/packages/veda-ui/graphics",
"$test": "~/test",
"$test": "~/apps/dashboard-parcel/test",
Copy link
Contributor

@ifsimicoded ifsimicoded Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, can tests be neutral to builds. If not, can this become parcel-test with a notice for deprecation and a TODO with a ticket number.

"$mock": "~/mock",
"$static": "~/static"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import NasaLogoColor from '../nasa-logo-color';
import { NavItem } from '../page-header/types.js';

import PageFooter from './index';
import { VedaUIConfigProvider } from '$test/utils.js';
import { VedaUIConfigProvider } from '$test/utils';
import { navItems } from '$mock/veda.config.js';

const defaultFooterSetting = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { BrowserRouter } from 'react-router-dom';
import NasaLogoColor from '../nasa-logo-color';
import { NavItem } from './types';
import PageHeader from './index';
import { VedaUIConfigProvider } from '$test/utils.js';
import { VedaUIConfigProvider } from '$test/utils';
import { navItems } from '$mock/veda.config.js';

// @NOTE: Possible Test cases
Expand Down
6 changes: 5 additions & 1 deletion playwright.config.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import { defineConfig, devices } from '@playwright/test';

/**
* E2E Tests for the Dashboard Application (apps/dashboard-parcel)
*/
export default defineConfig({
testDir: './test',
testDir: './apps/dashboard-parcel/test/playwright/tests',
testMatch: '**/*.spec.ts',
fullyParallel: true,
forbidOnly: !!process.env.CI,
retries: process.env.CI ? 2 : 0,
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"$data-layer/*": ["packages/veda-ui/src/data-layer/*"],
"$uswds": ["packages/veda-ui/src/uswds/"],
"$graphics/*": ["packages/veda-ui/graphics/*"],
"$test/*": ["test/*"],
"$test/*": ["apps/dashboard-parcel/test/*"],
"$mock/*": ["mock/*"],
"$storybook": ["storybook/*"]
}
Expand Down
Loading