Fix broken reference links and grammer updates #259
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
Author
There was a problem hiding this comment. Unsure why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Member
Author
There was a problem hiding this comment. There was no file named |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,147 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
|
|
||
| <meta http-equiv="content-type" content="text/html; charset=UTF-8" /> | ||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/leaflet.js"></script> | ||
| <script src="https://code.jquery.com/jquery-3.7.1.min.js"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/Leaflet.awesome-markers/2.0.2/leaflet.awesome-markers.js"></script> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/leaflet.css"/> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css"/> | ||
| <link rel="stylesheet" href="https://netdna.bootstrapcdn.com/bootstrap/3.0.0/css/bootstrap-glyphicons.css"/> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@fortawesome/[email protected]/css/all.min.css"/> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/Leaflet.awesome-markers/2.0.2/leaflet.awesome-markers.css"/> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/gh/python-visualization/folium/folium/templates/leaflet.awesome.rotate.min.css"/> | ||
|
|
||
| <meta name="viewport" content="width=device-width, | ||
| initial-scale=1.0, maximum-scale=1.0, user-scalable=no" /> | ||
| <style> | ||
| #map_d3e912f3a42c8ccf3fd73cb784ac925d { | ||
| position: relative; | ||
| width: 100.0%; | ||
| height: 100.0%; | ||
| left: 0.0%; | ||
| top: 0.0%; | ||
| } | ||
| .leaflet-container { font-size: 1rem; } | ||
| </style> | ||
|
|
||
| <style>html, body { | ||
| width: 100%; | ||
| height: 100%; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
| </style> | ||
|
|
||
| <style>#map { | ||
| position:absolute; | ||
| top:0; | ||
| bottom:0; | ||
| right:0; | ||
| left:0; | ||
| } | ||
| </style> | ||
|
|
||
| <script> | ||
| L_NO_TOUCH = false; | ||
| L_DISABLE_3D = false; | ||
| </script> | ||
|
|
||
|
|
||
| <script src="https://cdn.jsdelivr.net/gh/digidem/[email protected]/leaflet-side-by-side.min.js"></script> | ||
| </head> | ||
| <body> | ||
|
|
||
|
|
||
| <div class="folium-map" id="map_d3e912f3a42c8ccf3fd73cb784ac925d" ></div> | ||
|
|
||
| </body> | ||
| <script> | ||
|
|
||
|
|
||
| var map_d3e912f3a42c8ccf3fd73cb784ac925d = L.map( | ||
| "map_d3e912f3a42c8ccf3fd73cb784ac925d", | ||
| { | ||
| center: [40.0, -100.0], | ||
| crs: L.CRS.EPSG3857, | ||
| ...{ | ||
| "zoom": 4, | ||
| "zoomControl": true, | ||
| "preferCanvas": false, | ||
| } | ||
|
|
||
| } | ||
| ); | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| var tile_layer_ff8df70f1b5ec58cd1cc6010cb89bc8d = L.tileLayer( | ||
| "https://tile.openstreetmap.org/{z}/{x}/{y}.png", | ||
| { | ||
| "minZoom": 0, | ||
| "maxZoom": 19, | ||
| "maxNativeZoom": 19, | ||
| "noWrap": false, | ||
| "attribution": "\u0026copy; \u003ca href=\"https://www.openstreetmap.org/copyright\"\u003eOpenStreetMap\u003c/a\u003e contributors", | ||
| "subdomains": "abc", | ||
| "detectRetina": false, | ||
| "tms": false, | ||
| "opacity": 1, | ||
| } | ||
|
|
||
| ); | ||
|
|
||
|
|
||
| tile_layer_ff8df70f1b5ec58cd1cc6010cb89bc8d.addTo(map_d3e912f3a42c8ccf3fd73cb784ac925d); | ||
|
|
||
|
|
||
| var tile_layer_4df42e76a1f42c81b46cca0e2aa2045e = L.tileLayer( | ||
| "https://tile.openstreetmap.org/{z}/{x}/{y}.png", | ||
| { | ||
| "minZoom": 0, | ||
| "maxZoom": 19, | ||
| "maxNativeZoom": 19, | ||
| "noWrap": false, | ||
| "attribution": "\u0026copy; \u003ca href=\"https://www.openstreetmap.org/copyright\"\u003eOpenStreetMap\u003c/a\u003e contributors", | ||
| "subdomains": "abc", | ||
| "detectRetina": false, | ||
| "tms": false, | ||
| "opacity": 1, | ||
| } | ||
|
|
||
| ); | ||
|
|
||
|
|
||
| tile_layer_4df42e76a1f42c81b46cca0e2aa2045e.addTo(map_d3e912f3a42c8ccf3fd73cb784ac925d); | ||
|
|
||
|
|
||
| var tile_layer_e308300f3c232e205f3fce3fd50a1e5c = L.tileLayer( | ||
| "https://{s}.basemaps.cartocdn.com/light_all/{z}/{x}/{y}{r}.png", | ||
| { | ||
| "minZoom": 0, | ||
| "maxZoom": 20, | ||
| "maxNativeZoom": 20, | ||
| "noWrap": false, | ||
| "attribution": "\u0026copy; \u003ca href=\"https://www.openstreetmap.org/copyright\"\u003eOpenStreetMap\u003c/a\u003e contributors \u0026copy; \u003ca href=\"https://carto.com/attributions\"\u003eCARTO\u003c/a\u003e", | ||
| "subdomains": "abcd", | ||
| "detectRetina": false, | ||
| "tms": false, | ||
| "opacity": 1, | ||
| } | ||
|
|
||
| ); | ||
|
|
||
|
|
||
| tile_layer_e308300f3c232e205f3fce3fd50a1e5c.addTo(map_d3e912f3a42c8ccf3fd73cb784ac925d); | ||
|
|
||
|
|
||
| var side_by_side_layers_f237a06e227e03d3672adbe7b5761d3e = L.control.sideBySide( | ||
| tile_layer_4df42e76a1f42c81b46cca0e2aa2045e, tile_layer_e308300f3c232e205f3fce3fd50a1e5c | ||
| ).addTo(map_d3e912f3a42c8ccf3fd73cb784ac925d); | ||
|
|
||
| </script> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import folium | ||
| from folium.plugins import SideBySideLayers | ||
|
|
||
| # Create map | ||
| m = folium.Map(location=[40, -100], zoom_start=4) | ||
|
|
||
| # Create two tile layers | ||
| layer_left = folium.TileLayer( | ||
| tiles='openstreetmap', | ||
| name='OpenStreetMap' | ||
| ) | ||
|
|
||
| layer_right = folium.TileLayer( | ||
| tiles='cartodbpositron', | ||
| name='CartoDB' | ||
| ) | ||
|
|
||
| # IMPORTANT: Add layers to map FIRST | ||
| layer_left.add_to(m) | ||
| layer_right.add_to(m) | ||
|
|
||
| # Then create SideBySideLayers | ||
| sbs = SideBySideLayers(layer_left, layer_right) | ||
| sbs.add_to(m) | ||
|
|
||
| # Save and check | ||
| m.save('test_sbs.html') | ||
| print("Map saved to test_sbs.html") | ||
|
|
||
| # Check if the SideBySide JavaScript is included | ||
| html = m._repr_html_() | ||
| if 'leaflet-side-by-side' in html or 'sideBySide' in html: | ||
| print("✓ SideBySide plugin is included in the HTML") | ||
| else: | ||
| print("✗ SideBySide plugin NOT found in HTML") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| Test the new create_side_by_side_map function in plotutils.py | ||
| """ | ||
|
|
||
| import plotutils as putils | ||
|
|
||
| def test_create_side_by_side_map(): | ||
| """Test the create_side_by_side_map function""" | ||
|
|
||
| print("Testing create_side_by_side_map function...") | ||
| print("=" * 60) | ||
|
|
||
| # Create test tile URLs (these won't load real data but will test the function) | ||
| tiles_left = "https://example.com/reflectivity/{z}/{x}/{y}.png" | ||
| tiles_right = "https://example.com/velocity/{z}/{x}/{y}.png" | ||
|
|
||
| # Test with all parameters | ||
| m = putils.create_side_by_side_map( | ||
| tiles_url_left=tiles_left, | ||
| tiles_url_right=tiles_right, | ||
| center_coords=[41.668, -95.372], | ||
| zoom_level=14, | ||
| title="DOW7 Comparison: Reflectivity vs Velocity — Harlan, IA — April 26, 2024", | ||
| label_left="← Reflectivity (-10 to 50 dBZ)", | ||
| label_right="Velocity (-75 to 75 m/s) →", | ||
| layer_name_left="DOW7 Reflectivity", | ||
| layer_name_right="DOW7 Velocity", | ||
| opacity=0.8, | ||
| basemap_style='esri-satellite-labels', | ||
| description="Drag the slider to compare DOW-collected reflectivity and velocity values", | ||
| height="800px", | ||
| width="100%" | ||
| ) | ||
|
|
||
| # Save to file to check HTML structure | ||
| m.save('test_sidebyside_map.html') | ||
| print("✓ Map created and saved to test_sidebyside_map.html") | ||
|
|
||
| # Check if SideBySide JavaScript is included | ||
| html = m._repr_html_() | ||
| if 'leaflet-side-by-side' in html or 'sideBySide' in html: | ||
| print("✓ SideBySide plugin is included in the HTML") | ||
| else: | ||
| print("⚠ Warning: SideBySide plugin may not be properly included") | ||
|
|
||
| # Test with minimal parameters | ||
| print("\nTesting with minimal parameters...") | ||
| m2 = putils.create_side_by_side_map( | ||
| tiles_url_left=tiles_left, | ||
| tiles_url_right=tiles_right, | ||
| center_coords=[40, -100] | ||
| ) | ||
| print("✓ Minimal parameter test successful") | ||
|
|
||
| # Test without basemap | ||
| print("\nTesting without basemap...") | ||
| m3 = putils.create_side_by_side_map( | ||
| tiles_url_left=tiles_left, | ||
| tiles_url_right=tiles_right, | ||
| center_coords=[40, -100], | ||
| basemap_style=None | ||
| ) | ||
| print("✓ No basemap test successful") | ||
|
|
||
| print("\n" + "=" * 60) | ||
| print("All tests passed! The function is working correctly.") | ||
| print("\nThe function signature is:") | ||
| print("create_side_by_side_map(") | ||
| print(" tiles_url_left: str,") | ||
| print(" tiles_url_right: str,") | ||
| print(" center_coords: list,") | ||
| print(" zoom_level: int = 14,") | ||
| print(" title: str = 'Side-by-Side Comparison',") | ||
| print(" label_left: str = 'Left Layer',") | ||
| print(" label_right: str = 'Right Layer',") | ||
| print(" layer_name_left: str = 'Left Layer',") | ||
| print(" layer_name_right: str = 'Right Layer',") | ||
| print(" opacity: float = 0.8,") | ||
| print(" basemap_style: str = 'esri-satellite-labels',") | ||
| print(" description: str = None,") | ||
| print(" height: str = '800px',") | ||
| print(" width: str = '100%'") | ||
| print(")") | ||
|
|
||
| return True | ||
|
|
||
| if __name__ == "__main__": | ||
| test_create_side_by_side_map() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken reference link