Conversation
✅ Deploy Preview for visex ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Collaborator
danielfdsilva
left a comment
There was a problem hiding this comment.
@mccabete Looks good overall. Perhaps the map layer description could be improved. I imagine it could be the same as the dataset?
Contributor
Author
|
@danielfdsilva -- that's a great point. Could you point me to where I would edit that? For some reason I assumed that I could n't edit that section. |
Collaborator
|
@mccabete It's on that same file. Lines 21 and 23 I think. |
Collaborator
|
@mccabete Anything we can help with to get this merged? |
Contributor
Author
|
Hey, sorry to be holding this up! I'm OoO untill Monday. If you are ok with me making changes on the merged branch, then I am fine with it getting merged before my edits.
…________________________________
From: Daniel da Silva ***@***.***>
Sent: Wednesday, May 31, 2023 1:12 PM
To: NASA-IMPACT/veda-config ***@***.***>
Cc: Mccabe, Tempest ***@***.***>; Mention ***@***.***>
Subject: Re: [NASA-IMPACT/veda-config] Content: fire (PR #260)
@mccabete<https://github.com/mccabete> Anything we can help with to get this merged?
—
Reply to this email directly, view it on GitHub<#260 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFCH6FYHLTFIRXVG5T2UWVTXI53XRANCNFSM6AAAAAAYEE3W7I>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
|
This is just a PR onto another content branch. I'll merge this to reduce the number of PRs, we can track the evolution of this content on the other PR (#234). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding content
FEDS fire Perimeter description, with links to datasets based on FEDS fire perimeters. This is a first draft, that hasn't yet had feedback from wider EIS fire team. I will want to update the initial image, and will have more/different content. This should start a good group conversation though.
Any content
Datasets