Add support for Babylon tiles renderer #1389
Conversation
| "@vitejs/plugin-react": "^4.3.2", | ||
| "@vitest/eslint-plugin": "^1.5.1", | ||
| "babylonjs": "^7.0.0", | ||
| "babylonjs-loaders": "^7.0.0", |
There was a problem hiding this comment.
recommend using @babylonjs/core and @babylonjs/loaders. that will also allow us to move over to the es6 ImportMeshAsync in gltfloader (though im happy to submit a PR after this checkin though! )
| "eslint-plugin-react-hooks": "^5.0.0", | ||
| "globals": "^16.5.0", | ||
| "leva": "^0.10.0", | ||
| "lil-gui": "^0.21.0", |
There was a problem hiding this comment.
could perhaps use the bayblon GUI system here
| } | ||
|
|
||
| // Use unique filename to prevent texture caching issues | ||
| // TODO: What is the correct method for loading gltf files in babylon? |
There was a problem hiding this comment.
happy to submit follow-up PR importing "@babylonjs/loaders/glTF/2.0" and then using module-level ImportMeshAsync
|
@georginahalpern - thanks for the comments. All of the suggestions sound good to me so I'm happy to take PRs for them. I don't want to merge or publish babylon support before it's ready so if it's okay lets consider this |
|
@gkjohnson first PR with some minor changes |
Fix #387
Related to #1373
Related to #1375
Related to #1390
3d-tiles-renderer/babylonjs.TODO
Use the correct GLTF Loading systemUse correct importsAdd "events" support (dispatch? Other "babylonjs-esque" approach like observers?)Open Questions