Suggestion for version 5.0.2 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version adds the possibility to configure the CustomerID in the xml settings file instead of needing to pass it with the installer
…and InstallAgent-Core.psm1
If there was a CustomerID given through commandline, it was possible to run the powershell with an empty RegistrationToken. It's unlogic that you provide a CustomerID through commandline and the registration token through PartnerConfig.xml. If one is given and not the other it now quits with an error instead of trying to run the powershell script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version adds the CustomerID to the PartnerConfig.xml file. Giving you the possibility to change the CustomerID location from the GPO to the xml file. This way we can deploy the GPO to install the agent without user interaction and the xml file can easily be changed from within an AMP.
The old way to pass the Customers ID with the GPO still works and precedes the number given in the PartnerConfig.xml file.