chore: increase RocksDB background threads#3155
Merged
Conversation
1 task
Contributor
|
Warning: This PR modifies one of the example config files. Please consider the
|
mlegner
approved these changes
Mar 19, 2026
Contributor
mlegner
left a comment
mlegner
left a comment
There was a problem hiding this comment.
Looks reasonable and didn't cause any (additional) issues on our node. 👍
There was a problem hiding this comment.
Pull request overview
This PR updates Walrus storage-node RocksDB configuration to increase background compaction/flush concurrency by introducing a configurable max_background_jobs option (defaulting to 16) and wiring it into the RocksDB Options used when opening the DB.
Changes:
- Add
global.max_background_jobstoGlobalDatabaseOptions(default16) and apply it viaOptions::set_max_background_jobs. - Update the sample node config (
node_config_example.yaml) to includemax_background_jobs: 16. - (Also included) Flip
enable_statisticsdefaults/example totrue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/walrus-service/src/node/storage/database_config.rs |
Adds a new global RocksDB option for max background jobs and applies it when building rocksdb::Options; also changes enable_statistics default. |
crates/walrus-service/node_config_example.yaml |
Documents the new max_background_jobs setting in the example config; also changes enable_statistics example value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+249
to
251
| max_background_jobs: Some(16), | ||
| enable_statistics: true, | ||
| use_optimistic_transaction_db: true, |
Comment on lines
+11
to
13
| max_background_jobs: 16 | ||
| enable_statistics: true | ||
| use_optimistic_transaction_db: true |
Comment on lines
+288
to
+290
| if let Some(max_background_jobs) = value.max_background_jobs { | ||
| options.set_max_background_jobs(max_background_jobs); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increases the number of RocksDB background threads from 2 (RocksDB default) to 16. Can be configured through the config file.
Test plan
Deployment to ML storage nodes.
Release notes