feat: Add metric to track if recovery deferral cancelled a recovery#3132
Open
sadhansood wants to merge 2 commits intomainfrom
Open
feat: Add metric to track if recovery deferral cancelled a recovery#3132sadhansood wants to merge 2 commits intomainfrom
sadhansood wants to merge 2 commits intomainfrom
Conversation
shuowang12
reviewed
Mar 16, 2026
Comment on lines
+594
to
+604
| if waited_for_deferral { | ||
| this.node | ||
| .metrics | ||
| .live_upload_deferral_avoided_recovery_total | ||
| .inc(); | ||
| walrus_utils::with_label!( | ||
| this.node.metrics.live_upload_deferral_outcome_total, | ||
| LIVE_UPLOAD_DEFERRAL_OUTCOME_AVOIDED_RECOVERY | ||
| ) | ||
| .inc(); | ||
| } |
Collaborator
There was a problem hiding this comment.
I was wondering if there is difference between live_upload_deferral_avoided_recovery_total and live_upload_deferral_outcome_total[LIVE_UPLOAD_DEFERRAL_OUTCOME_AVOIDED_RECOVERY].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a recovery deferral stopped a recovery from happening, it is useful to track it.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)