You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)
Claude says: Soft-invariant streak counters are not reset on skipped rounds in Antithesis observer. When a node
is unreachable the round is skipped via continue, but event_source_streak and fully_stored_streak retain their previous values. This means non-consecutive violations separated by skipped rounds still accumulate toward the patience threshold, causing false-positive crashes in the exact fault-injection environment (Antithesis) where the script runs. Fix: reset both streak counters to 0 inside the all_ok=false branch before continue. (docker/walrus-antithesis/build-test-config-image/files/run-observer.sh:170-185)
Claude says: Soft-invariant streak counters are not reset on skipped rounds in Antithesis observer. When a node is unreachable the round is skipped via continue, but event_source_streak and fully_stored_streak retain their previous values. This means non-consecutive violations separated by skipped rounds still accumulate toward the patience threshold, causing false-positive crashes in the exact fault-injection environment (Antithesis) where the script runs. Fix: reset both streak counters to 0 inside the all_ok=false branch before continue. (docker/walrus-antithesis/build-test-config-image/files/run-observer.sh:170-185)
Thanks for the notes. I am still trying to figure out how to run the Antithesis tests against a branch/PR and thus created this draft PR. Will address the issue later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)