fix: start prometheus metrics server in aggregator for scraping#514
Merged
quepcompute merged 1 commit intomainfrom Mar 12, 2026
Merged
fix: start prometheus metrics server in aggregator for scraping#514quepcompute merged 1 commit intomainfrom
quepcompute merged 1 commit intomainfrom
Conversation
joyqvq
approved these changes
Mar 12, 2026
quepcompute
force-pushed
the
kporter/seal-aggregator-metrics
branch
from
8afafa9 to
08dfc66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The aggregator server creates a prometheus registry and pushes metrics via
spawn_metrics_push_job, but never starts an HTTP server to serve/metrics. This means grafana-alloy (which discovers pods viaprometheus.io/scrape: "true"annotations) tries to scrapepod_ip:9184/metricsbut nothing is listening, resulting inup=0.This adds
start_basic_prometheus_server()to bind a prometheus HTTP server on0.0.0.0:9184, matching what the key server already does. Both push and pull metrics now work.Test Plan
cargo check --bin aggregator-serverpassesup{namespace="seal-aggregator-testnet"} == 1in Grafana/metricsendpoint responds:curl <pod_ip>:9184/metrics