[TASK] Upgrade to PHPStan 2.x and Rector 2.x #777
Conversation
oliverklee
added
dependencies
oliverklee
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
oliverklee
modified the milestones:
9.0.0: Drop support for PHP < 7.2 and clean up things,
10.0.0
|
For this change, we'll need to drop support for PHP < 7.4 first. |
PHP 7.4 just becomes a dev requirement, not a minimum requirement for the package. Ideally we can find a way of running the versions of the tools compatible with the version contraints. Oh, Composer. It's what it's there for. |
composer.json
Outdated
| "phpstan/phpstan": "2.0.3", | ||
| "phpstan/phpstan-phpunit": "2.0.1", |
There was a problem hiding this comment.
I think we need an OR-list of versions, e.g. "phpstan/phpstan": ".12.0 || 2.0.3". That way we can have the new version installed when the PHP environment allows, whilst also continuing to support older PHP versions.
oliverklee
modified the milestones:
10.0.0,
9.0.0: Drop support for PHP < 7.2 and clean up things
oliverklee
force-pushed
the
task/update-rector-phpstan
branch
from
01c6f86 to
d10a5ca
Compare
Also add some more return type declarations as added by the new Rector version.
oliverklee
force-pushed
the
task/update-rector-phpstan
branch
from
d10a5ca to
3580e45
Compare
| - dependency-name: "phpunit/phpunit" | ||
| versions: [ ">= 9.0.0" ] |
There was a problem hiding this comment.
Yes, we probably don't want the bot to try a major update of PHPUnit, which would be incompatible.
|
I removed the non-applicable commit message that was separately done with #778. |
No description provided.