Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add composer-normalize to our development toolchain #765

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[FEATURE] Add composer-normalize to our development toolchain #765

merged 1 commit into from
Nov 7, 2024

Conversation

oliverklee
Copy link
Contributor

No description provided.

@oliverklee oliverklee added enhancement developer-specific Issues that only affect maintainers, contributors, and people submitting PRs labels Nov 7, 2024
@oliverklee oliverklee requested a review from JakeQZ November 7, 2024 07:58
@oliverklee oliverklee self-assigned this Nov 7, 2024
@coveralls
Copy link

coveralls commented Nov 7, 2024 •
edited
Loading

Coverage Status

coverage: 38.622%. remained the same
when pulling 52b9e51 on feature/normalize
into 3ef8030 on main.

@oliverklee oliverklee marked this pull request as draft November 7, 2024 08:01
@oliverklee oliverklee force-pushed the feature/normalize branch 3 times, most recently from 5eba37e to 9cba418 Compare November 7, 2024 08:07
JakeQZ
JakeQZ approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks complete, with implementation consistent with the same in Emogrifier.

.github/workflows/ci.yml Show resolved Hide resolved
@JakeQZ
Copy link
Contributor

JakeQZ commented Nov 7, 2024

I guess the check is failing because we needed to normilize composer.json first.

@JakeQZ JakeQZ mentioned this pull request Nov 7, 2024
Merged
@JakeQZ
Copy link
Contributor

JakeQZ commented Nov 7, 2024

I guess the check is failing because we needed to normilize composer.json first.

With a rebase to include #766 this can now be merged.

@oliverklee oliverklee mentioned this pull request Nov 7, 2024
Closed
@oliverklee oliverklee marked this pull request as ready for review November 7, 2024 21:11
@oliverklee oliverklee enabled auto-merge (squash) November 7, 2024 21:11
@oliverklee oliverklee disabled auto-merge November 7, 2024 21:11
@oliverklee oliverklee merged commit 08f56a1 into main Nov 7, 2024
21 checks passed
@oliverklee oliverklee deleted the feature/normalize branch November 7, 2024 21:12
@oliverklee oliverklee mentioned this pull request Jan 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
developer-specific Issues that only affect maintainers, contributors, and people submitting PRs enhancement
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ