Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Autoformat the code #440

Merged
merged 1 commit into from
Feb 4, 2024
Merged

[CLEANUP] Autoformat the code #440

merged 1 commit into from
Feb 4, 2024

Conversation

oliverklee
Copy link
Contributor

Autoformat the code with the default PhpStorm settings (and re-run composer fix:php to minimize formatting-related changes when code is changed and autoformatted.

Autoformat the code with the default PhpStorm settings (and re-run
`composer fix:php` to minimize formatting-related changes when
code is changed and autoformatted.
Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOC, all good. Are we PSR-4, or something else?

@JakeQZ JakeQZ merged commit b0c1403 into master Feb 4, 2024
26 checks passed
@JakeQZ JakeQZ deleted the cleanup/autoformat branch February 4, 2024 01:44
@oliverklee
Copy link
Contributor Author

Are we PSR-4, or something else?

For autoloading, we're using PSR-4: https://github.com/sabberworm/PHP-CSS-Parser/blob/master/composer.json#L37

And as coding standard, we're using some mix of PSR-12, PER and a home-made mix. (We might want to move to PER2 at some point to keep up with the PHP ecosystem. I've just added #442 for this.)

oliverklee added a commit that referenced this pull request Feb 10, 2024
Autoformat the code with the default PhpStorm settings (and re-run
`composer fix:php` to minimize formatting-related changes when
code is changed and autoformatted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants