Skip to content

[CLEANUP] Avoid negated non-Boolean in RuleSet #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

[CLEANUP] Avoid negated non-Boolean in RuleSet #1246

merged 1 commit into from
Apr 14, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 13, 2025

Use === null instead to be more precise.

@JakeQZ
[CLEANUP] Avoid negated non-Boolean in RuleSet
ccf01dd 
Use `=== null` instead to be more precise.
@JakeQZ JakeQZ added the cleanup label Apr 13, 2025
@JakeQZ JakeQZ requested a review from oliverklee April 13, 2025 23:30
@JakeQZ JakeQZ self-assigned this Apr 13, 2025
@coveralls
Copy link

Coverage Status

coverage: 56.225%. remained the same
when pulling ccf01dd on cleanup/negated-bool/ruleset
into 03ed64a on main.

@oliverklee oliverklee merged commit 9dbc6a6 into main Apr 14, 2025
21 checks passed
@oliverklee oliverklee deleted the cleanup/negated-bool/ruleset branch April 14, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee