Skip to content

[TASK] Refactor getAllValues() #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

[TASK] Refactor getAllValues() #1244

merged 1 commit into from
Apr 13, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 13, 2025 •
edited
Loading

Move functionality from allValues() directly into to getAllValues(), so as to avoid passing array by reference, removing allValues(). Avoid making the recursive call for nested items that are not CSSElements.

Part of #994.
Closes #1230.

@JakeQZ JakeQZ added the cleanup label Apr 13, 2025
@JakeQZ JakeQZ requested a review from oliverklee April 13, 2025 21:51
@JakeQZ JakeQZ self-assigned this Apr 13, 2025
@coveralls
Copy link

coveralls commented Apr 13, 2025 •
edited
Loading

Coverage Status

coverage: 56.225% (+0.2%) from 55.977%
when pulling 70b9ce7 on task/refactor/getallvalues
into 4429cc2 on main.

@JakeQZ JakeQZ force-pushed the task/refactor/getallvalues branch from 4bcd15c to 70b9ce7 Compare April 13, 2025 21:55
@JakeQZ
[TASK] Refactor getAllValues()
c02b02b 
Move functionality from `allValues()` directly into to `getAllValues()`,
so as to avoid passing array by reference, removing `allValues()`.
Avoid making the recursive call for nested items that are not `CSSElement`s.

Part of #994.
Closes #1230.
@JakeQZ JakeQZ force-pushed the task/refactor/getallvalues branch from 70b9ce7 to c02b02b Compare April 13, 2025 21:56
oliverklee
oliverklee approved these changes Apr 13, 2025
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oliverklee oliverklee merged commit 03ed64a into main Apr 13, 2025
@oliverklee oliverklee deleted the task/refactor/getallvalues branch April 13, 2025 22:13
@JakeQZ JakeQZ added the refactor For PRs that refactor code without changing functionality label Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
cleanup refactor For PRs that refactor code without changing functionality
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeQZ @coveralls @oliverklee