Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Add and implement Positionable interface #1232

Merged
merged 9 commits into from
Apr 7, 2025
Merged

[TASK] Add and implement Positionable interface #1232

merged 9 commits into from
Apr 7, 2025

Conversation

JakeQZ
Copy link
Contributor

@JakeQZ JakeQZ commented Apr 6, 2025

This is the backport of #1221 and #1225 for #1207.

@JakeQZ JakeQZ self-assigned this Apr 6, 2025
@JakeQZ JakeQZ marked this pull request as draft April 6, 2025 22:36
@JakeQZ JakeQZ force-pushed the backport/positionable branch from f82fd72 to e15ad16 Compare April 6, 2025 22:43
@JakeQZ JakeQZ force-pushed the backport/positionable branch from e15ad16 to 70ae485 Compare April 6, 2025 23:03
@JakeQZ JakeQZ force-pushed the backport/positionable branch 3 times, most recently from a5d4c26 to c1ec88c Compare April 6, 2025 23:54
@JakeQZ JakeQZ force-pushed the backport/positionable branch from c1ec88c to 4ecf7d9 Compare April 7, 2025 00:07
@JakeQZ
Allow "rawr/cross-data-providers" version compatible with PHP 7.0
7bef887 
This version supposedly supports PHP 5.6,
but seems to have different class names, so is not compatible.

Instead, on 5.6, mark tests as skipped if they can't be run.
@JakeQZ JakeQZ force-pushed the backport/positionable branch from 5b82d2c to 7bef887 Compare April 7, 2025 00:33
JakeQZ added a commit that referenced this pull request Apr 7, 2025
@JakeQZ
[TASK] Deprecate getLineNo() etc. in v8.9.0
151827a 
The deprecation and changes from #1207 can be merged to 8.x.
See #1232.

So the deprecation can be brought forward.
@JakeQZ JakeQZ mentioned this pull request Apr 7, 2025
Merged
oliverklee pushed a commit that referenced this pull request Apr 7, 2025
@JakeQZ
[TASK] Deprecate getLineNo() etc. in v8.9.0 (#1233)
6f3e955 
The deprecation and changes from #1207 can be merged to 8.x.
See #1232.

So the deprecation can be brought forward.
JakeQZ added 2 commits April 7, 2025 19:15
@JakeQZ
Apply #1233 (and #1235)
e06ed2e 
Also include the relevant DocBlock reordering from autoformatting in #1228.
@JakeQZ
[TASK] Update CHANGELOG for #1233 (#1235)
0c586e7
@JakeQZ JakeQZ requested a review from oliverklee April 7, 2025 18:20
@JakeQZ JakeQZ marked this pull request as ready for review April 7, 2025 18:20
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Apr 7, 2025

There are several commits to squash. Viewing them individually may aid reviewing.

oliverklee
oliverklee approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oliverklee oliverklee merged commit e100b80 into v8.x Apr 7, 2025
22 checks passed
@oliverklee oliverklee deleted the backport/positionable branch April 7, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
backport cleanup
Projects
None yet
Milestone
8.9.0: Deprecations and bug fixes
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeQZ @oliverklee