[CLEANUP] Return null from DeclarationBlock::parse() on failure
#1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeQZ
added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone
|
|
Also add clarification of meaning of return value from `CSSList::parseListItem()`, where `null` and `false` have different meanings. Part of #1176.
JakeQZ
force-pushed
the
cleanup/declaration-block-parse-return-null
branch
from
ddbe63e to
1e8ca90
Compare
|
This is ready for review now. (I can't see how to re-request review when a previous review has not been done.) |
oliverklee
requested changes
Mar 24, 2025
JakeQZ
force-pushed
the
cleanup/declaration-block-parse-return-null
branch
from
71f6e0e to
3914812
Compare
oliverklee
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add clarification of meaning of return value from
CSSList::parseListItem(), wherenullandfalsehave different meanings.Part of #1176.