MCR-3602 Corrupted checksums when renaming a derivate's files#2803
Open
os-cau wants to merge 1 commit intoMyCoRe-Org:2023.06.xfrom
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
we need this fix also for 2023.06, can you rebase this? |
When renaming a file using MCRDerivateServlet, a corrupted checksum will be written to mcrdata.xml. The reason for this is that the call to Files.move() does not include the COPY_ATTRIBUTES flag. This commits adds the missing flag.
f9413a8 to
a9c6d38
Compare
Contributor
Author
I have rebased the PR onto 2023.06 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When renaming a file using MCRDerivateServlet, a corrupted checksum will be written to mcrdata.xml.
The reason for this is that the call to Files.move() does not include the COPY_ATTRIBUTES flag.
This commit adds the missing flag.
Link to jira.
Pull Request Checklist (Author)
Please go through the following checklist before assigning the PR for review:
Ticket & Documentation
fixed-versionis correctly set in the ticket and matches the PR's target branch (main).Feature & Improvement Specific Checks
Bugfix-Specific Checks
Testing
MCR Conventions & Metadata
mycore.properties.mycore.properties.Multi-Repo Considerations
MIRrequired?