Skip to content

MCR-3602 Corrupted checksums when renaming a derivate's files#2803

Open
os-cau wants to merge 1 commit intoMyCoRe-Org:2023.06.xfrom
os-cau:issues/mcr-3602-corrupted-checksums-when-renaming-a-derivate-s-files
Open

MCR-3602 Corrupted checksums when renaming a derivate's files#2803
os-cau wants to merge 1 commit intoMyCoRe-Org:2023.06.xfrom
os-cau:issues/mcr-3602-corrupted-checksums-when-renaming-a-derivate-s-files

Conversation

@os-cau
Copy link
Contributor

@os-cau os-cau commented Feb 3, 2026

When renaming a file using MCRDerivateServlet, a corrupted checksum will be written to mcrdata.xml.

The reason for this is that the call to Files.move() does not include the COPY_ATTRIBUTES flag.

This commit adds the missing flag.

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

Bugfix-Specific Checks

  • Affected version is listed in the ticket.
  • Minimal code changes were made (no refactoring).
  • This PR truly fixes only the reported bug.
  • No breaking changes are introduced.
  • A relevant test was added (if feasible).

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@os-cau

This comment was marked as resolved.

@kkrebs kkrebs requested a review from sebhofmann February 10, 2026 13:48
@kkrebs
Copy link
Contributor

kkrebs commented Feb 10, 2026

we need this fix also for 2023.06, can you rebase this?

When renaming a file using MCRDerivateServlet, a corrupted checksum will
be written to mcrdata.xml.

The reason for this is that the call to Files.move() does not include
the COPY_ATTRIBUTES flag.

This commits adds the missing flag.
@os-cau os-cau force-pushed the issues/mcr-3602-corrupted-checksums-when-renaming-a-derivate-s-files branch from f9413a8 to a9c6d38 Compare February 12, 2026 08:16
@os-cau os-cau changed the base branch from 2025.06.x to 2023.06.x February 12, 2026 08:17
@os-cau
Copy link
Contributor Author

os-cau commented Feb 12, 2026

we need this fix also for 2023.06, can you rebase this?

I have rebased the PR onto 2023.06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants