Skip to content

MCR-3600 Turn MCRXMLMetadataManager into an interface#2796

Open
toKrause wants to merge 4 commits intomainfrom
issues/MCR-3600_Turn-MCRXMLMetadataManager-into-an-interface
Open

MCR-3600 Turn MCRXMLMetadataManager into an interface#2796
toKrause wants to merge 4 commits intomainfrom
issues/MCR-3600_Turn-MCRXMLMetadataManager-into-an-interface

Conversation

@toKrause
Copy link
Contributor

@toKrause toKrause commented Jan 29, 2026

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

MyCoRe-Org/mycore-website#130

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

Test now configure and use an MCRXMLMetadatamanager instead of an MCRXMLMetadataManagerAdapter,

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

@toKrause toKrause requested a review from yagee-de January 29, 2026 14:16
@toKrause toKrause force-pushed the issues/MCR-3600_Turn-MCRXMLMetadataManager-into-an-interface branch from 5fbf040 to 269cd9a Compare January 29, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant