Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: Install the libmpd.so output on android #2031

Merged
merged 1 commit into from
May 6, 2024

Conversation

DDRBoxman
Copy link
Contributor

libmpd.so was getting written as a file called arm64-v8a instead of arm64-v8a/libmpd.so

@MaxKellermann
Copy link
Member

This time you're adding a Python script instead of a shell script, which is better... but this still looks more complicated than it should be. Isn't there another, simpler way to do this?
Also your old commit 906d58a looks pretty wrong. It does not properly declare the target file; it pretends to output to OUTPUT/android/apk/libmpd.so (via output: parameter) but it really copies to meson.current_source_dir()/.... - due to this mistake, Ninja is unable to find the output file and thus copies the file again even if it already exists.

@DDRBoxman
Copy link
Contributor Author

Looks like output is just for names and can't take a path. Setting up the install path and calling install might be an option?

@DDRBoxman DDRBoxman changed the title android: Correctly copy the libmpd.so output android: Install the libmpd.so output on android Apr 23, 2024
@DDRBoxman
Copy link
Contributor Author

Okay, switched this over to use install

libmpd.so was getting written as a file called `arm64-v8a` instead of `arm64-v8a/libmpd.so`
@MaxKellermann MaxKellermann merged commit 79df6a6 into MusicPlayerDaemon:master May 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants