Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event/TimerList: Add custom compare for android #2020

Closed

Conversation

DDRBoxman
Copy link
Contributor

NDK doesn't seem to support using std::compare_three_way for time_point so this implements that.

NDK doesn't seem to support using std::compare_three_way for time_point
so this implements that.
@DDRBoxman
Copy link
Contributor Author

Interesting looks like macOS is failing on std::compare_three_way missing too 🤔

@MaxKellermann
Copy link
Member

Interesting looks like macOS is failing on std::compare_three_way missing too 🤔

It's because both Android NDK and macOS ship with an outdated libc++ version which didn't implement this part of C++20.

I don't like this PR because it adds code noise to all platforms, even those that are standards-compliant. At least this should be #ifed and come with a proper explanatory comment. But I guess we could just as well wait for NDK r27 which should be here any day now.

(I don't care for macOS. It's a broken platform with a broken toolchain.)

@DDRBoxman
Copy link
Contributor Author

I'm fine with waiting for r27 instead

@DDRBoxman DDRBoxman closed this Apr 9, 2024
@MaxKellermann
Copy link
Member

r27-beta1 is out: https://dl.google.com/android/repository/android-ndk-r27-beta1-linux.zip
(I havn't yet tested whether this release fixes the libc++ bug.)

@MaxKellermann
Copy link
Member

Now tested. NDK r27-beta1 has the fix for this C++20 bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants