Skip to content

Commit

Permalink
decoder/List: prefer "mpg123" over "mad"
Browse files Browse the repository at this point in the history
libmad hasn't been maintained for many many years, while libmpg123 is
still maintained.

Our "mad" plugin can't do streams, but MPD will automatically fall
back to "mad" (or "ffmpeg") for streams.

Closes #1954
  • Loading branch information
MaxKellermann committed Apr 3, 2024
1 parent b6afdf1 commit 65e5a43
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions NEWS
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ ver 0.24 (not yet released)
- ffmpeg: require FFmpeg 4.0 or later
- ffmpeg: query supported demuxers at runtime
- hybrid_dsd: remove
- mpg123: prefer over "mad"
- opus: implement bitrate calculation
- sidplay: require libsidplayfp (drop support for the original sidplay)
- wavpack: require libwavpack version 5
Expand Down
6 changes: 3 additions & 3 deletions src/decoder/DecoderList.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@
#include <string.h>

constinit const struct DecoderPlugin *const decoder_plugins[] = {
#ifdef ENABLE_MAD
&mad_decoder_plugin,
#endif
#ifdef ENABLE_MPG123
&mpg123_decoder_plugin,
#endif
#ifdef ENABLE_MAD
&mad_decoder_plugin,
#endif
#ifdef ENABLE_VORBIS_DECODER
&vorbis_decoder_plugin,
#endif
Expand Down

0 comments on commit 65e5a43

Please sign in to comment.