Update zip dependency to fix GCC14 build error #759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zip submodule is built with
-Wextra -Werror
. At the very least with GCC14, this results in an error raised by calloc-transposed-args due to a call to calloc where the arguments are swapped around. I've fixed this upstream, and this is pulling the update in. At the time of writing, this means jumping to latest master, involving a jump from 0.2.x to 0.3.x. The minor bump seems to be due to the addition of some new functions.It should be noted that I'm unable to successfully run ctest since I end up with
This is potentially connected with #546, but in my case I'm just trying to build it locally on my Fedora 40 installation. Additionally, test 17 (but not 18 or 23) fails on my Fedora 38 virtual machine both before and after updating this dependency.
Merge request created anyway since there's clearly a need to either update the zip dependency, or build with different settings for GCC14.