Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunk header does not interfere with line wrapping #720

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

jensenr30
Copy link
Contributor

The Hunk Header was interfering with line wrapping. This video shows how the Hunk Header causes the line wrapping to stop working:

gittyup-line-wrap-header-1-no-wrap.webm

This PR fixes this issue by making the hunk header resize itself according to the size of the DiffView windows:

gittyup-line-wrap-header-2-wrap.webm

Also, the DiffView still has line wrapping disabled by default. When line wrapping is disabled, the new Hunk Header still works as expected:

gittyup-line-wreap-header-3-no-line-wrap.webm

@Murmele
Copy link
Owner

Murmele commented Mar 21, 2024

I have to check why the appdata check does not work anymore.
I created an issue I have to checkout the linux build problem: #722

@Murmele Murmele merged commit 063099a into Murmele:master Mar 28, 2024
11 checks passed
@jensenr30 jensenr30 deleted the hunk-header branch April 4, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants