Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix staging #122

Merged
merged 20 commits into from
Apr 3, 2022
Merged

Fix staging #122

merged 20 commits into from
Apr 3, 2022

Conversation

Murmele
Copy link
Owner

@Murmele Murmele commented Mar 31, 2022 •
edited
Loading

The first should be selected, but it is the last. Don't know if this can be change.
But when clicking on the first deletion the last gets selected

image

@Murmele Murmele marked this pull request as ready for review April 2, 2022 10:08
@Murmele Murmele mentioned this pull request Apr 2, 2022
Closed
exactly-one-kas
exactly-one-kas requested changes Apr 2, 2022
View reviewed changes
Copy link
Collaborator

@exactly-one-kas exactly-one-kas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a bit of cleanup that needs to be done and some preprocessor abuse this looks fine

src/ui/DiffView/HunkWidget.cpp Outdated Show resolved Hide resolved
src/ui/DiffView/HunkWidget.cpp Outdated Show resolved Hide resolved
src/ui/DiffView/HunkWidget.cpp Outdated Show resolved Hide resolved
test/EditorLineInfos.cpp Outdated Show resolved Hide resolved
test/EditorLineInfos.cpp Outdated Show resolved Hide resolved
@Murmele
Copy link
Owner Author

Murmele commented Apr 2, 2022

Aside from a bit of cleanup that needs to be done and some preprocessor abuse this looks fine

Thanks for reviewing. For some reason the windows build failed

@Murmele Murmele mentioned this pull request Apr 2, 2022
Merged
@exactly-one-kas
Copy link
Collaborator

For some reason the windows build failed

Yep, I unresolved the #define review comment with additional information

@Murmele
Copy link
Owner Author

Murmele commented Apr 2, 2022

For some reason the windows build failed

Yep, I unresolved the #define review comment with additional information

sorry there I was too fast

@exactly-one-kas exactly-one-kas added the bug Something isn't working label Apr 3, 2022
@Murmele Murmele merged commit 0b97959 into master Apr 3, 2022
@Murmele Murmele deleted the fixStaging branch January 27, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exactly-one-kas exactly-one-kas exactly-one-kas approved these changes

@stefanknotzer stefanknotzer Awaiting requested review from stefanknotzer

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Murmele @exactly-one-kas