Update the Stripe SDK to the latest version and the Stripe API to the latest version#647
Merged
Merged
Conversation
Contributor
|
Not within scope of this PR bc I think the payments frontend is on our goals to redesign shortly, one thing to note is that it is clunky that I have to remove a card on file first and then add a new card from within billing settings for it to stick. Approved PR with understanding checks will be fixed |
duckduckgrayduck
approved these changes
Apr 29, 2026
process_overdue_invoice was calling organization.subscription_cancelled() which always cancels the org's current subscription. When an overdue invoice was linked to a different subscription (or had no subscription at all), this cancelled the wrong subscription entirely. - Change process_overdue_invoice to pass invoice.subscription explicitly - Add optional subscription parameter to Organization.subscription_cancelled - Skip cancellation when invoice has no linked subscription Closes #672 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
12392b5 to
eea8abf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #644
This needs heavy testing on the review app to ensure new API calls function correctly