Adds oembed redirect and a home for more redirects#1319
Merged
Conversation
|
Preview deployed: https://preview-1319.staging.documentcloud.org |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Contributor
|
I've confirmed that
I can't seem to test if /api/oembed.json with a URL parameter redirects or not, because the front-end assets are a different link than the documents on the backend |
Collaborator
Author
|
I confirmed that this forwards query params: https://preview-1319.staging.documentcloud.org/api/oembed.json?url=https://preview-1319.staging.documentcloud.org/documents/20011330-pioservices/ The staging server doesn't recognize the domain, so it 404s, but that's fine. |
Contributor
|
Yea, that's basically what I was getting at, otherwise looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw 404s on
/api/oembed.json/, so this ensures we normalize the URL and redirect correctly. Once this merges, we can remove the version in the CF dashboard.I also added a
(redirects)directory so these stay in one place and don't clutter up other routes. The/appredirect is there now.