Skip to content

Conversation

@michaelmackenzie
Copy link
Contributor

This allows for the creation of the EventWindowMarker when creating the EventHeader object Online. There are also a few minor edits to the EventHeader creation logic. The EventHeader definition should be reviewed in a future discussion, to ensure we have the necessary data in it without unnecessarily increasing its size (which directly impacts the data volume of the luminosity stream).

@FNALbuild
Copy link
Collaborator

Hi @michaelmackenzie,
You have proposed changes to files in these packages:

  • DAQ

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for df426c1: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☔ The build tests failed for df426c1.

Test Result Details
test with Command did not list any other PRs to include
merge Merged df426c1 at 440d6ec
build (prof) Log file. Build time: 04 min 35 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file. Return Code 9.
ceSteps Log file.
ceDigi Log file. Return Code 9.
muDauSteps Log file.
ceMix Log file. Return Code 9.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 2.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy ➡️ 2 errors 10 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at df426c1 after being merged into the base branch at 440d6ec.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@michaelmackenzie
Copy link
Contributor Author

@FNALbuild run build test with Mu2e/mu2e-trig-config#134

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for df426c1: build (Build queue - API unavailable)

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at df426c1.

Test Result Details
test with Included Mu2e/mu2e-trig-config#134 @ c02fde82b0f662ca12e6a7341f6d841611bad181 by merge
merge Merged df426c1 at 440d6ec
build (prof) Log file. Build time: 04 min 33 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy ➡️ 2 errors 10 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at df426c1 after being merged into the base branch at 440d6ec.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Copy link
Contributor

@rrivera747 rrivera747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tick unit is 25ns in the CFO event duration - so should be revised!

Copy link
Contributor

@rrivera747 rrivera747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tick should be 25ns

@rrivera747
Copy link
Contributor

From CFO User Guide, docdb 5619:
image

@michaelmackenzie
Copy link
Contributor Author

@FNALbuild run build test with Mu2e/mu2e-trig-config#134

@FNALbuild
Copy link
Collaborator

⌛ The following tests have been triggered for 03385a1: build (Build queue - API unavailable)

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 03385a1.

Test Result Details
test with Included Mu2e/mu2e-trig-config#134 @ c02fde82b0f662ca12e6a7341f6d841611bad181 by merge
merge Merged 03385a1 at cdbcae2
build (prof) Log file. Build time: 04 min 36 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy ➡️ 2 errors 10 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 03385a1 after being merged into the base branch at cdbcae2.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants