[Feature] Make Blocks Preview Stick Job Do Server Side & Add Container Signature and Container Trace to Mark Unique Containers#36
Conversation
|
I don't really see much reason to make the previews server-side handled, there's support for AE2 and RS2 when you use Benbenlaw's addon mods. |
|
Actually, Benbenlaw's addon mods implement server-side reviews because of the lack of the original mod. (And some players said they want support of PortableCell :( . ) If trying to make more addons, server-side reviews must be implemented in every addon. Space…… Maybe caused by VSCode, I will recheck it. |
|
I did forget to include my .editorconfig in the main branch, it exists on newer branches |
|
in terms of addons it would probably be better to have the preview stuff avaible server side and would remove the need for addons to implement networking and probably does open up a lot of options for other additional mod support |
What does this PR do?
How does this PR change?
Make blocks preview stickjob do server-side
PacketRequestPreview&PacketPreviewResult.RenderBlockPreview, replacestickJobwithlastRayTraceResultandlastStickto cache and send them to the server side.stickJoband usesPacketPreviewResultto send the blocks to the client side.Add ContainerSignature and ContainerTrace to mark unique containers
ContainerTraceto trace containers that have been used.IContainerHandler, force ContainerHandlers to implementgetSignaturemethod.ContainerManager.Why?
Now,
ContainerManagercould deal with local storage like Shulker Boxes and Sophisticated Backpacks.But there are also remote storage in many other mods like AE2, RS2, Lightland backpacks, and Beyond Dimension, which could only be read on the server side and don't bind with a specific item.
These two changes will make
ContainerManagersupport remote storage, and slightly improve the search performance.