Skip to content

Fix undefined values (Q and H) and rotation feature #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charlyBerthet wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix undefined values (Q and H) and rotation feature #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e531d
Fix undefined values + rotation
charlyBerthet Jan 5, 2021
11d5275
Merge pull request #1 from charlyBerthet/fix-undefined-values-and-rot…
charlyBerthet Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions src/pages/Cropper.page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ import { Animated, PanResponder } from 'react-native';
import ImageEditor from "@react-native-community/image-editor";
import RNImageRotate from 'react-native-image-rotate';
import PropTypes from 'prop-types';
import { SCREEN_WIDTH, SCREEN_HEIGHT, W, MINIMUM_CROP_AREA } from '../components/Cropper/Cropper.constants';
import { SCREEN_WIDTH, SCREEN_HEIGHT, W, MINIMUM_CROP_AREA, Q as QDefault } from '../components/Cropper/Cropper.constants';
import Cropper from '../components/Cropper/Cropper.component';
import { getCropperLimits } from '../utils';

class CropperPage extends Component {
constructor(props) {
super(props);
const { imageWidth, imageHeight, BORDER_WIDTH, FOOTER_HEIGHT } = props;
const Q = FOOTER_HEIGHT // to set Footer Height
const Q = FOOTER_HEIGHT || QDefault; // to set Footer Height
const H = SCREEN_HEIGHT - Q
const W_INT = W - (2 * BORDER_WIDTH);
const H_INT = H - (2 * BORDER_WIDTH);
Expand Down Expand Up @@ -523,6 +523,8 @@ class CropperPage extends Component {
}

onRotate = () => {
const Q = this.props.FOOTER_HEIGHT || QDefault;
const H = SCREEN_HEIGHT - Q
const W_INT = W - (2 * this.props.BORDER_WIDTH);
const H_INT = H - (2 * this.props.BORDER_WIDTH);
let imageWidth = 0;
Expand Down Expand Up @@ -610,15 +612,12 @@ class CropperPage extends Component {
resizeMode: 'stretch'
};

// Rotation is removed for now

// RNImageRotate.rotateImage(
// this.props.imageUri,
// this.state.rotation,
// (rotatedUri) => {
//
ImageEditor.cropImage(this.props.imageUri, cropData).then(croppedUri => {
console.warn('croppeddata from cropper', croppedUri)
RNImageRotate.rotateImage(
this.props.imageUri,
this.state.rotation,
(rotatedUri) => {
ImageEditor.cropImage(rotatedUri, cropData).then(croppedUri => {
console.log('croppeddata from cropper', croppedUri)
const croppedImageData = {
width,
height,
Expand All @@ -631,13 +630,12 @@ class CropperPage extends Component {
console.log(err);
}
);
//
// },
// (err) => {
// alert(err);
// console.log(err);
// }
// );
},
(err) => {
alert(err);
console.log(err);
}
);
}

render() {
Expand Down