Skip to content

Add account ordering with up/down controls in account panel#491

Open
5sig2 wants to merge 2 commits into
Moulberry:masterfrom
5sig2:account-reorder
Open

Add account ordering with up/down controls in account panel#491
5sig2 wants to merge 2 commits into
Moulberry:masterfrom
5sig2:account-reorder

Conversation

@5sig2

@5sig2 5sig2 commented May 12, 2026

Copy link
Copy Markdown
Contributor

QoL feature, adding reorder controls to the accounts panel
Accounts now keep a saved order (with migration for old accounts.json), new accounts append to the bottom.

Screenshot 2026-05-12 100941

Closes #424

@disconnectedgrinders

Copy link
Copy Markdown

Yes this is cool, but Id like to add onto this that if #445 gets the drag to reorder feature. That should also be used here.

@5sig2

5sig2 commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

Yes this is cool, but Id like to add onto this that if #445 gets the drag to reorder feature. That should also be used here.

I originally wanted to do a drag reorder for this, but I'm bad at UI and couldn't really think of any way to add "dragging" to this, because of the delete button mainly, I wasn't sure how I could handle it.

@disconnectedgrinders

Copy link
Copy Markdown

I can make a mockup later if you would want that.

@Moulberry

Copy link
Copy Markdown
Owner

Use an IndexMap instead of a HashMap, it'll maintain order for you without needing a separate vec

@disconnectedgrinders

Copy link
Copy Markdown

@5sig2 Something like this would be ideal in case of drag and drop. If you need a better visualization just @me

example.mp4

@5sig2

5sig2 commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

@5sig2 Something like this would be ideal in case of drag and drop. If you need a better visualization just @me

example.mp4

hmm, my main issue is how to handle the buttons, we can't have it be exclusively drag drop, and we can't get rid of the delete button on the accounts either, so I'm not sure how we handle THAT specifically, if you maybe give me a idea or even a visualization of how we should handle that, I'd be willing to code it up alongside the indexmap rework

@disconnectedgrinders

Copy link
Copy Markdown

Yeah sure I can make that tomorrow, just now im thinking we can combine the delete button with the container of the account in some way. But ill work on some designs tmr.

@disconnectedgrinders

Copy link
Copy Markdown

Sorry for the late response but here:

Version 1 is easier to apply to more parts of the program, but version 2 is overal smoother in my opinion.

2026-05-28.20-57-30.mp4

@xCheezie

Copy link
Copy Markdown

I need that

@5sig2

5sig2 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the late response but here:

Version 1 is easier to apply to more parts of the program, but version 2 is overal smoother in my opinion.

2026-05-28.20-57-30.mp4

Ok this is definitely a good UI solution, I'll work on this as soon as my exams end.

I'll also be keeping the up and down arrows within the hover animation (next to the delete button) , as some people may want to use the buttons rather than dragging.

@disconnectedgrinders

Copy link
Copy Markdown

No worries, take your time and thank you for working on this.

@disconnectedgrinders

Copy link
Copy Markdown

Also if your up for it doing the exact same for the server lists would be ideal.

@xCheezie

Copy link
Copy Markdown

How long it gonna take to be implemented in the laucher

@5sig2

5sig2 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

@disconnectedgrinders I believe this should suffice as a good implementation
https://github.com/user-attachments/assets/7741b1ed-0265-4f2a-a08c-b78fd7b8c5df

@5sig2

5sig2 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

How long it gonna take to be implemented in the laucher

I believe moulberry is busy with axiom, when he's free he will start working on all the open pull requests and various issues, and this will likely be merged alongside it. it can take anywhere from a couple days to weeks if he is busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add the ability to reorder the account list.

4 participants