Skip to content

Refactor counter wrap-around logic into helper function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Refactor counter wrap-around logic into helper function #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6d7002d
Initial plan
Copilot Feb 17, 2026
df3a8ea
Refactor counter wrap-around logic into helper function
Copilot Feb 17, 2026
511c51f
Address code review feedback: use uint32_t and narrow variable scope
Copilot Feb 17, 2026
f53a919
Simplify wrap-around calculation using unsigned arithmetic
Copilot Feb 17, 2026
a2f307f
Improve documentation for wrap-around handling
Copilot Feb 17, 2026
9795371
Clarify wrap-around example in documentation
Copilot Feb 17, 2026
b8b1643
Fix wrap-around example explanation
Copilot Feb 17, 2026
6f5a246
Final: Code review and security checks complete
Copilot Feb 17, 2026
0191215
Remove build artifacts and update .gitignore
Copilot Feb 17, 2026
341415f
RDKB-63040: [TXB7/TXB8]: Observed Packet Error Count Marker updated w…
MothiShree Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,29 @@ install/
*.o
*.so
.vscode/

# Build artifacts
Makefile
Makefile.in
config.h
config.h.in
config.log
config.status
configure
aclocal.m4
autom4te.cache/
compile
config.guess
config.sub
depcomp
install-sh
libtool
ltmain.sh
m4/
missing
stamp-h1
_codeql_detected_source_root
INSTALL
.deps/
*.Po
*.Plo
68 changes: 48 additions & 20 deletions source/apps/whix/wifi_whix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,17 @@ void print_sta_client_telemetry_data(unsigned int num_devs, int vap_index, sta_d
#define CLIENT_TELEMETRY_PARAM_MAX_LEN 64
#define MAX_BUFF_SIZE BSS_MAX_NUM_STATIONS *CLIENT_TELEMETRY_PARAM_MAX_LEN

static inline unsigned long calculate_counter_delta(unsigned long current, unsigned long previous)
{
unsigned long diff = 0;
if (curr >= prev) {
diff = curr - prev;
} else {
diff = (ULONG_MAX - prev) + curr + 1;
}
return diff;
}

int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigned int vap_index,
sta_data_t *sta)
{
Expand All @@ -1276,6 +1287,7 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
wifi_mgr_t *wifi_mgr = (wifi_mgr_t *)get_wifimgr_obj();
hash_map_t *last_stats_map = app->data.u.whix.last_stats_map;
wifi_associated_dev3_t *dev_stats_last = NULL;
unsigned long del = 0, curr = 0 , prev = 0;

if (NULL == sta && num_devs != 0) {
wifi_util_error_print(WIFI_APPS, "%s:%d sta is NULL and num_devs %u\n", __func__, __LINE__,
Expand Down Expand Up @@ -1659,8 +1671,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
hash_map_put(app->data.u.whix.last_stats_map, strdup(sta_key), dev_stats_last);
}
if (sta[i].dev_stats.cli_Active == true) {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_BytesSent - dev_stats_last->cli_BytesSent);
curr = sta[i].dev_stats.cli_BytesSent;
prev = dev_stats_last->cli_BytesSent;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
}
}
Expand All @@ -1681,8 +1695,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
__LINE__);
snprintf(tmp, 32, "%u,", 0);
} else {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_BytesReceived - dev_stats_last->cli_BytesReceived);
curr = sta[i].dev_stats.cli_BytesReceived;
prev = dev_stats_last->cli_BytesReceived;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
}
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
}
Expand All @@ -1705,8 +1721,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
__LINE__);
snprintf(tmp, 32, "%u,", 0);
} else {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_PacketsSent - dev_stats_last->cli_PacketsSent);
curr = sta[i].dev_stats.cli_PacketsSent;
prev = dev_stats_last->cli_PacketsSent;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
}
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
strncat(telemetryBuff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
Expand Down Expand Up @@ -1737,8 +1755,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
__LINE__);
snprintf(tmp, 32, "%u,", 0);
} else {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_PacketsReceived - dev_stats_last->cli_PacketsReceived);
curr = sta[i].dev_stats.cli_PacketsReceived;
prev = dev_stats_last->cli_PacketsReceived;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
}
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
}
Expand All @@ -1761,8 +1781,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
__LINE__);
snprintf(tmp, 32, "%u,", 0);
} else {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_ErrorsSent - dev_stats_last->cli_ErrorsSent);
curr = sta[i].dev_stats.cli_ErrorsSent;
prev = dev_stats_last->cli_ErrorsSent;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
}
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
strncat(telemetryBuff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
Expand Down Expand Up @@ -1793,8 +1815,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
__LINE__);
snprintf(tmp, 32, "%u,", 0);
} else {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_RetransCount - dev_stats_last->cli_RetransCount);
curr = sta[i].dev_stats.cli_RetransCount;
prev = dev_stats_last->cli_RetransCount;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
}
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
strncat(telemetryBuff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
Expand Down Expand Up @@ -1824,9 +1848,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
__LINE__);
snprintf(tmp, 32, "%u,", 0);
} else {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_FailedRetransCount -
dev_stats_last->cli_FailedRetransCount);
curr = sta[i].dev_stats.cli_FailedRetransCount;
prev = dev_stats_last->cli_FailedRetransCount;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
}
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
}
Expand All @@ -1848,8 +1873,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
__LINE__);
snprintf(tmp, 32, "%u,", 0);
} else {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_RetryCount - dev_stats_last->cli_RetryCount);
curr = sta[i].dev_stats.cli_RetryCount;
prev = dev_stats_last->cli_RetryCount;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
}
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
}
Expand All @@ -1871,9 +1898,10 @@ int upload_client_telemetry_data(wifi_app_t *app, unsigned int num_devs, unsigne
__LINE__);
snprintf(tmp, 32, "%u,", 0);
} else {
snprintf(tmp, 32, "%lu,",
sta[i].dev_stats.cli_MultipleRetryCount -
dev_stats_last->cli_MultipleRetryCount);
curr = sta[i].dev_stats.cli_MultipleRetryCount;
prev = dev_stats_last->cli_MultipleRetryCount;
del = calculate_counter_delta(curr, prev);
snprintf(tmp, 32, "%lu,", del);
}
strncat(buff, tmp, MAX_BUFF_SIZE - strlen(buff) - 1);
}
Expand Down
Loading