feat: Add support for install-multiple#39
Open
hoo-dles wants to merge 1 commit into
Open
Conversation
hoo-dles
commented
May 8, 2026
| } | ||
|
|
||
| override suspend fun install(apks: List<Apk>): RootInstallerResult { | ||
| TODO() |
Contributor
Author
There was a problem hiding this comment.
I don't have any experience with mounting, so I'm not sure what to do here
Contributor
There was a problem hiding this comment.
Can leave it a Todo and restrict CLI usage to non root or throw an exception if root is attempted
Contributor
Author
There was a problem hiding this comment.
Ok, need me to do anything else? I think the TODO() throws already, correct?
Contributor
There was a problem hiding this comment.
Yes it throws a not implemented exception.
Looks ready to merge to me.
LisoUseInAIKyrios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step in getting the CLI support for install apk split bundles.