Upgrade to Sorbet 0.4.5036

eml.gemspec

@@ -35,7 +35,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rubocop-performance"
   spec.add_development_dependency "rubocop-rspec"
   spec.add_development_dependency "simplecov"
-  spec.add_development_dependency "sorbet"
+  spec.add_development_dependency "sorbet", ">= 0.4.5036", "< 1.0"
   spec.add_development_dependency "vcr"
   spec.add_development_dependency "webmock"
 end

lib/eml/error/rest/internal_server.rb

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 module EML

lib/eml/error/tns.rb

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 module EML

lib/eml/lib/basic_auth/generate.rb

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 require "base64"

lib/eml/lib/basic_auth/verify.rb

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 module EML

lib/eml/lib/constant_time_compare.rb

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: false
 # frozen_string_literal: true
 
 module EML

lib/eml/parameters.rb

@@ -61,9 +61,12 @@ def convert_with_endpoint_class(
     sig { returns(T::Hash[Symbol, T.untyped]) }
     def to_h
       instance_variables.each_with_object({}) do |variable_name, params|
-        key = variable_name.to_s[1..-1].to_sym
+        key = T.must(variable_name.to_s[1..-1]).to_sym
         params[key] = instance_variable_get(variable_name)
-        params[key] = params[key].to_h if params[key].respond_to?(:to_h)
+
+        if !params[key].nil? && params[key].respond_to?(:to_h)
+          params[key] = params[key].to_h
+        end
       end
     end
 
@@ -98,7 +101,7 @@ def validate_max_length(param_name, param_value, length)
 
     private
 
-    sig { params(array: T::Array[String]).returns(String) }
+    sig { params(array: T::Array[Symbol]).returns(String) }
     def array_as_string(array)
       array.dup.tap { |vals| vals[-1] = "or #{vals.last}" }.join(", ")
     end

lib/eml/payload.rb

@@ -62,7 +62,7 @@ def convert_with_endpoint_class(
     sig { returns(T::Hash[Symbol, T.untyped]) }
     def to_h
       instance_variables.each_with_object({}) do |variable_name, params|
-        key = variable_name.to_s[1..-1].to_sym
+        key = T.must(variable_name.to_s[1..-1]).to_sym
         params[key] = instance_variable_get(variable_name)
         params[key] = params[key].to_h if params[key].respond_to?(:to_h)
       end

lib/eml/response.rb

@@ -9,7 +9,7 @@ class Response
     def self.field(field_name)
       define_method(field_name) do
         string_name = field_name.to_s
-        body[string_name]
+        T.unsafe(self).body[string_name]
       end
     end
 

lib/eml/uk/models/tns/card.rb

@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 module EML

lib/eml/uk/models/transaction.rb

@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML

lib/eml/uk/parameters.rb

@@ -12,6 +12,9 @@ class Parameters < ::EML::Parameters
       def initialize(params)
         params = merge_required_config(params)
         params = merge_optional_config(params)
+
+        @search_parameter = T.let(nil, T.nilable(String))
+
         super
       end
 

lib/eml/uk/parameters/agreement/show.rb

@@ -1,19 +1,20 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Agreement
         class Show < ::EML::UK::Parameters
+          sig { params(params: T::Hash[T.untyped, T.untyped]).void }
           def initialize(params)
             params[:client_language] ||= "en"
             super
           end
 
           private
 
-          sig { params(client_language: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :client_language
         end
       end

lib/eml/uk/parameters/card/activation.rb

@@ -1,15 +1,15 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Activation < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }

lib/eml/uk/parameters/card/lock.rb

@@ -1,17 +1,17 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Lock < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
           private
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }

lib/eml/uk/parameters/card/register.rb

@@ -1,15 +1,15 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Register < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }

lib/eml/uk/parameters/card/reload.rb

@@ -1,15 +1,15 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Reload < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }

lib/eml/uk/parameters/card/show.rb

@@ -1,15 +1,15 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Show < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
-          FIELDS_OPTIONS = %i[
+          FIELDS_OPTIONS = T.let(%i[
             account_expiration_date
             activating_merchant_group_name
             activating_merchant_group_uniquetag
@@ -59,7 +59,16 @@ class Show < ::EML::UK::Parameters
             status
             uri
             unload_to_ach_fee
-          ].freeze
+          ].freeze, T::Array[Symbol])
+
+          sig { params(params: T::Hash[Symbol, T.untyped]).void }
+          def initialize(params)
+            super
+
+            @fields = T.let(nil, T.nilable(String))
+            @log_balance_inquiry = T.let(nil, T.nilable(String))
+            @only_valid_status = T.let(nil, T.nilable(String))
+          end
 
           sig { params(fields: T::Array[Symbol]).returns(String) }
           def fields=(fields)
@@ -82,7 +91,7 @@ def only_valid_status=(only_valid_status)
             @only_valid_status = only_valid_status.inspect
           end
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }
@@ -91,7 +100,7 @@ def search_parameter=(search_parameter)
             @search_parameter = search_parameter
           end
 
-          sig { params(security_code: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :security_code
         end
       end

lib/eml/uk/parameters/card/transaction.rb

@@ -1,17 +1,17 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Transaction < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
           private
 
-          FIELDS_OPTIONS = %i[
+          FIELDS_OPTIONS = T.let(%i[
             activity
             amount
             authorization_request_id
@@ -28,7 +28,14 @@ class Transaction < ::EML::UK::Parameters
             system_transaction_id
             timestamp
             user
-          ].freeze
+          ].freeze, T::Array[Symbol])
+
+          sig { params(params: T::Hash[Symbol, T.untyped]).void }
+          def initialize(params)
+            super
+
+            @fields = T.let(nil, T.nilable(String))
+          end
 
           sig { params(fields: T::Array[Symbol]).returns(String) }
           def fields=(fields)
@@ -41,10 +48,10 @@ def fields=(fields)
             @fields = fields.join(",")
           end
 
-          sig { params(filter: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :filter
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }

lib/eml/uk/parameters/card/unload.rb

@@ -1,17 +1,17 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Unload < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
           private
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }

lib/eml/uk/parameters/card/unlock.rb

@@ -1,17 +1,17 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Unlock < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
           private
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }

lib/eml/uk/parameters/card/void.rb

@@ -1,17 +1,17 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 module EML
   module UK
     class Parameters
       module Card
         class Unlock < ::EML::UK::Parameters
-          REQUIRED_CONFIG = %i[program].freeze
-          OPTIONAL_CONFIG = %i[search_parameter].freeze
+          REQUIRED_CONFIG = T.let(%i[program].freeze, T::Array[Symbol])
+          OPTIONAL_CONFIG = T.let(%i[search_parameter].freeze, T::Array[Symbol])
 
           private
 
-          sig { params(program: String).returns(String) }
+          sig { returns(T.nilable(String)) }
           attr_accessor :program
 
           sig { params(search_parameter: String).returns(String) }