fix: copy transcript #674
Open
fix: copy transcript #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![pr-agent-monadical[bot]](https://avatars.githubusercontent.com/u/29933591?s=60&v=4){kind=small}
Comment on lines
+145
to
+173
| navigator.clipboard | ||
| .writeText(text) | ||
| .then(() => { | ||
| toaster | ||
| .create({ | ||
| placement: "top", | ||
| duration: 2500, | ||
| render: () => ( | ||
| <div className="chakra-ui-light"> | ||
| <div | ||
| style={{ | ||
| background: "#38A169", | ||
| color: "white", | ||
| padding: "8px 12px", | ||
| borderRadius: 6, | ||
| display: "flex", | ||
| alignItems: "center", | ||
| gap: 8, | ||
| boxShadow: "rgba(0,0,0,0.25) 0px 4px 12px", | ||
| }} | ||
| > | ||
| <LuCheck /> Transcript copied | ||
| </div> | ||
| </div> | ||
| ), | ||
| }) | ||
| .then(() => {}); | ||
| }) | ||
| .catch(() => {}); |
There was a problem hiding this comment.
Suggestion: Add proper error handling in the clipboard operation's catch block to inform the user when copying fails, rather than silently ignoring errors. [general, importance: 7]
Suggested change
| navigator.clipboard | |
| .writeText(text) | |
| .then(() => { | |
| toaster | |
| .create({ | |
| placement: "top", | |
| duration: 2500, | |
| render: () => ( | |
| <div className="chakra-ui-light"> | |
| <div | |
| style={{ | |
| background: "#38A169", | |
| color: "white", | |
| padding: "8px 12px", | |
| borderRadius: 6, | |
| display: "flex", | |
| alignItems: "center", | |
| gap: 8, | |
| boxShadow: "rgba(0,0,0,0.25) 0px 4px 12px", | |
| }} | |
| > | |
| <LuCheck /> Transcript copied | |
| </div> | |
| </div> | |
| ), | |
| }) | |
| .then(() => {}); | |
| }) | |
| .catch(() => {}); | |
| navigator.clipboard | |
| .writeText(text) | |
| .then(() => { | |
| toaster | |
| .create({ | |
| placement: "top", | |
| duration: 2500, | |
| render: () => ( | |
| <div className="chakra-ui-light"> | |
| <div | |
| style={{ | |
| background: "#38A169", | |
| color: "white", | |
| padding: "8px 12px", | |
| borderRadius: 6, | |
| display: "flex", | |
| alignItems: "center", | |
| gap: 8, | |
| boxShadow: "rgba(0,0,0,0.25) 0px 4px 12px", | |
| }} | |
| > | |
| <LuCheck /> Transcript copied | |
| </div> | |
| </div> | |
| ), | |
| }) | |
| .then(() => {}); | |
| }) | |
| .catch((error) => { | |
| toaster.create({ | |
| placement: "top", | |
| duration: 2500, | |
| render: () => ( | |
| <div className="chakra-ui-light"> | |
| <div | |
| style={{ | |
| background: "#E53E3E", | |
| color: "white", | |
| padding: "8px 12px", | |
| borderRadius: 6, | |
| display: "flex", | |
| alignItems: "center", | |
| gap: 8, | |
| boxShadow: "rgba(0,0,0,0.25) 0px 4px 12px", | |
| }} | |
| > | |
| Failed to copy transcript | |
| </div> | |
| </div> | |
| ), | |
| }); | |
| }); |
Comment on lines
+139
to
+145
| const text = buildTranscriptWithTopics( | ||
| props.topicsResponse || [], | ||
| participantsQuery?.data || null, | ||
| props.transcriptResponse?.title || null, | ||
| ); | ||
| if (!text) return; | ||
| navigator.clipboard |
There was a problem hiding this comment.
Suggestion: Check if participantsQuery is still loading before using its data. The current implementation might cause issues if the query hasn't completed when the copy function is triggered. [possible issue, importance: 8]
Suggested change
| const text = buildTranscriptWithTopics( | |
| props.topicsResponse || [], | |
| participantsQuery?.data || null, | |
| props.transcriptResponse?.title || null, | |
| ); | |
| if (!text) return; | |
| navigator.clipboard | |
| if (participantsQuery.isLoading) { | |
| toaster.create({ | |
| placement: "top", | |
| duration: 2500, | |
| render: () => ( | |
| <div className="chakra-ui-light"> | |
| <div style={{ | |
| background: "#ED8936", | |
| color: "white", | |
| padding: "8px 12px", | |
| borderRadius: 6, | |
| display: "flex", | |
| alignItems: "center", | |
| gap: 8, | |
| boxShadow: "rgba(0,0,0,0.25) 0px 4px 12px", | |
| }}> | |
| Please wait for participant data to load | |
| </div> | |
| </div> | |
| ), | |
| }); | |
| return; | |
| } | |
| const text = buildTranscriptWithTopics( | |
| props.topicsResponse || [], | |
| participantsQuery?.data || null, | |
| props.transcriptResponse?.title || null, | |
| ); | |
| if (!text) return; |
Comment on lines
+7
to
+13
| function getSpeakerName( | ||
| speakerNumber: number, | ||
| participants?: Participant[] | null, | ||
| ): string { | ||
| const name = participants?.find((p) => p.speaker === speakerNumber)?.name; | ||
| return name && name.trim().length > 0 ? name : `Speaker ${speakerNumber}`; | ||
| } |
There was a problem hiding this comment.
Suggestion: Add a type check for speakerNumber before using it to find a participant. If speakerNumber is undefined or null, the function might return incorrect results. [general, importance: 6]
Suggested change
| function getSpeakerName( | |
| speakerNumber: number, | |
| participants?: Participant[] | null, | |
| ): string { | |
| const name = participants?.find((p) => p.speaker === speakerNumber)?.name; | |
| return name && name.trim().length > 0 ? name : `Speaker ${speakerNumber}`; | |
| } | |
| function getSpeakerName( | |
| speakerNumber: number, | |
| participants?: Participant[] | null, | |
| ): string { | |
| if (speakerNumber === undefined || speakerNumber === null) { | |
| return "Unknown Speaker"; | |
| } | |
| const name = participants?.find((p) => p.speaker === speakerNumber)?.name; | |
| return name && name.trim().length > 0 ? name : `Speaker ${speakerNumber}`; | |
| } |
This was
linked to
issues
Sep 29, 2025
tito
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
PR Type
Enhancement
Description
Add transcript copy functionality with formatting
Include speaker names and timestamps
Show success notification on copy
Improve transcript formatting with topics
Changes walkthrough 📝
finalSummary.tsx
Add transcript copy button with success notificationwww/app/(app)/transcripts/[transcriptId]/finalSummary.tsx
buildTranscriptWithTopicsbuildTranscriptWithTopics.ts
Create transcript formatting utilitywww/app/(app)/transcripts/buildTranscriptWithTopics.ts
shareCopy.tsx
Update transcript copy with new formatting utilitywww/app/(app)/transcripts/shareCopy.tsx
buildTranscriptWithTopicsutilityuseTranscriptParticipantshook