feat: add background information for room context in summaries #517
Conversation
- Add background_information field to Room database table and model - Create database migration for the new field - Update API schemas (CreateRoom, UpdateRoom) to handle background_information - Integrate room context into AI summarization prompts - Add background_information field to frontend room form - Update TypeScript types from regenerated OpenAPI spec The background information will be used to provide context for AI-generated summaries, helping create more appropriate and relevant meeting summaries. 🤖 Generated with [opencode](https://opencode.ai) Co-Authored-By: opencode <[email protected]>
|
Someone is attempting to deploy this pull request to the Monadical Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![pr-agent-monadical[bot]](https://avatars.githubusercontent.com/u/29933591?s=60&v=4){kind=small}
| builder = SummaryBuilder(self.llm, room=self.room) | ||
| builder.set_transcript(text) | ||
| await builder.identify_participants() | ||
| await builder.generate_summary() |
There was a problem hiding this comment.
Suggestion: The builder variable is being used before it's assigned. You need to assign the result of SummaryBuilder() to the builder variable and also assign it to self.builder for later reference. [possible issue, importance: 8]
| builder = SummaryBuilder(self.llm, room=self.room) | |
| builder.set_transcript(text) | |
| await builder.identify_participants() | |
| await builder.generate_summary() | |
| async def get_summary_builder(self, text) -> SummaryBuilder: | |
| builder = SummaryBuilder(self.llm, room=self.room) | |
| self.builder = builder | |
| builder.set_transcript(text) | |
| await builder.identify_participants() | |
| await builder.generate_summary() |
| export type CreateRoom = { | ||
| /** | ||
| * Name | ||
| */ | ||
| name: string; | ||
| /** | ||
| * Zulip Auto Post | ||
| */ | ||
| zulip_auto_post: boolean; | ||
| /** | ||
| * Zulip Stream | ||
| */ | ||
| zulip_stream: string; | ||
| /** | ||
| * Zulip Topic | ||
| */ | ||
| zulip_topic: string; | ||
| /** | ||
| * Is Locked | ||
| */ | ||
| is_locked: boolean; | ||
| /** | ||
| * Room Mode | ||
| */ | ||
| room_mode: string; | ||
| /** | ||
| * Recording Type | ||
| */ | ||
| recording_type: string; | ||
| /** | ||
| * Recording Trigger | ||
| */ | ||
| recording_trigger: string; | ||
| /** | ||
| * Is Shared | ||
| */ | ||
| is_shared: boolean; | ||
| /** | ||
| * Background Information | ||
| */ | ||
| background_information?: string; | ||
| }; |
There was a problem hiding this comment.
Suggestion: The background_information field is optional in CreateRoom but required in Room. This inconsistency could lead to type errors when creating rooms. Consider making the field consistently optional or required in both types. [possible issue, importance: 7]
| export type CreateRoom = { | |
| /** | |
| * Name | |
| */ | |
| name: string; | |
| /** | |
| * Zulip Auto Post | |
| */ | |
| zulip_auto_post: boolean; | |
| /** | |
| * Zulip Stream | |
| */ | |
| zulip_stream: string; | |
| /** | |
| * Zulip Topic | |
| */ | |
| zulip_topic: string; | |
| /** | |
| * Is Locked | |
| */ | |
| is_locked: boolean; | |
| /** | |
| * Room Mode | |
| */ | |
| room_mode: string; | |
| /** | |
| * Recording Type | |
| */ | |
| recording_type: string; | |
| /** | |
| * Recording Trigger | |
| */ | |
| recording_trigger: string; | |
| /** | |
| * Is Shared | |
| */ | |
| is_shared: boolean; | |
| /** | |
| * Background Information | |
| */ | |
| background_information?: string; | |
| }; | |
| export type CreateRoom = { | |
| /** | |
| * Name | |
| */ | |
| name: string; | |
| /** | |
| * Zulip Auto Post | |
| */ | |
| zulip_auto_post: boolean; | |
| /** | |
| * Zulip Stream | |
| */ | |
| zulip_stream: string; | |
| /** | |
| * Zulip Topic | |
| */ | |
| zulip_topic: string; | |
| /** | |
| * Is Locked | |
| */ | |
| is_locked: boolean; | |
| /** | |
| * Room Mode | |
| */ | |
| room_mode: string; | |
| /** | |
| * Recording Type | |
| */ | |
| recording_type: string; | |
| /** | |
| * Recording Trigger | |
| */ | |
| recording_trigger: string; | |
| /** | |
| * Is Shared | |
| */ | |
| is_shared: boolean; | |
| /** | |
| * Background Information | |
| */ | |
| background_information: string | null; | |
| }; |
tito
force-pushed
the
codingagent/issue-516
branch
from
866b8f7 to
47cb75e
Compare
1 participant
User description
Summary
This PR implements the ability to add background information to rooms that will be used to provide context for AI-generated summaries. This addresses issue #516 by allowing users to specify the purpose and context of a room, which helps the AI generate more appropriate and relevant meeting summaries.
Changes Made
Backend Changes
background_informationfield to Room table with migrationSummaryBuilderto accept room contextTranscriptFinalSummaryProcessorto pass room informationFrontend Changes
Key Areas for Review
background_informationTEXT field to maintain backward compatibilityTesting
Fixes #516
🤖 Generated with opencode
PR Type
Enhancement
Description
Add background information field to rooms
Integrate room context into AI summaries
Update database with migration
Add UI field in room form
Changes walkthrough 📝
12 files
Add background_information field to Room modelCreate database migration for new fieldUpdate API schemas to include background_informationEnhance system prompt with room contextPass room information to summary builderAdd room retrieval to pipelineUpdate TypeScript types with new fieldGenerate SDK with updated typesAdd background information field to room formAdd client utilities for API integrationDefine client type definitionsImplement API client functionality23 files