Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change vim.g.transparency check to vim.g.transparent #76

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

baco
Copy link
Contributor

@baco baco commented Jul 16, 2022

Also test for boolean values of backwards compatible configs on top of
the already tested integer values.

Also test for boolean values of backwards compatible configs on top of
the already tested integer values.
@baco
Copy link
Contributor Author

baco commented Jul 16, 2022

@yochem here is the fix. Closes #71

@yochem
Copy link
Contributor

yochem commented Jul 17, 2022

maybe add it to the the disable_nvimtree_bg option too? so it checks for both true and 1. That would make it most complete.

Just for completeness add the same validation for all the backwards
compatible options in vim-script.
@baco
Copy link
Contributor Author

baco commented Jul 17, 2022

Ok, it wasn't there in the first place (the check for equality with the literal 1), that's why I didn't bother, but I get the sense of completeness in adding it there too.

@Mofiqul Mofiqul merged commit 0742e59 into Mofiqul:main Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants