Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 8, 2025

Change Summary

Browser redirects on local Keycloak installation are broken because of CORS. Instead return 401 code which will be handled by UI.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Coverage

Coverage Report •
FileStmtsMissCoverMissing
syncmaster/server
   handler.py1572584%57, 62, 70, 72, 76, 81, 91, 112, 118–120, 210–212, 226–227, 241–242, 315–317, 329–332
syncmaster/server/api/v1
   auth.py21290%32, 40
syncmaster/server/providers/auth
   keycloak_provider.py75988%26–28, 71–72, 105–107, 110
TOTAL474726394% 

@dolfinus dolfinus marked this pull request as ready for review October 8, 2025 11:30
@dolfinus dolfinus merged commit f5af023 into develop Oct 8, 2025
24 checks passed
@dolfinus dolfinus deleted the improvement/DOP-29772 branch October 8, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants