Skip to content

Conversation

@dolfinus
Copy link
Member

@dolfinus dolfinus commented Dec 23, 2024

Change Summary

  • Do not call blocking methods of Keycloak client inside async def methods of AuthProvider.
  • Fix annotations for get_current_user method.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Dec 23, 2024
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Dec 23, 2024
@dolfinus dolfinus marked this pull request as ready for review October 8, 2025 13:44
@dolfinus dolfinus removed the ci:skip-changelog Add this label to skip changelog file check label Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Coverage

Coverage Report •
FileStmtsMissCoverMissing
syncmaster/server/providers/auth
   dummy_provider.py592262%29–30, 57–58, 60–65, 67–69, 71–73, 80–81, 85, 90, 100–101
   keycloak_provider.py811581%28–30, 70–71, 102–104, 107, 140–141, 145–148
TOTAL477227294% 

@dolfinus dolfinus merged commit 542e14d into develop Oct 9, 2025
25 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-23122 branch October 9, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants