Skip to content

Conversation

@IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Nov 15, 2024

Change Summary

Unified the database field naming convention across all JDBC types to use database_name, except for Oracle, which uses service_name and sid.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment added the ci:skip-changelog Add this label to skip changelog file check label Nov 15, 2024
@IlyasDevelopment IlyasDevelopment self-assigned this Nov 15, 2024
Copy link
Member

@dolfinus dolfinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may require some changes on UI side

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (651f00c) to head (b29a008).
Report is 75 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #130   +/-   ##
========================================
  Coverage    90.42%   90.42%           
========================================
  Files          157      157           
  Lines         3560     3560           
  Branches       261      261           
========================================
  Hits          3219     3219           
  Misses         277      277           
  Partials        64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlyasDevelopment IlyasDevelopment merged commit 3b3baa7 into develop Nov 15, 2024
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-21415 branch November 15, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants