Skip to content

Conversation

@IlyasDevelopment
Copy link
Contributor

@IlyasDevelopment IlyasDevelopment commented Nov 14, 2024

Change Summary

The commit in PR #118 led to a 5% decrease in coverage (in particular, it was about worker module). The initial value has now been restored.

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@IlyasDevelopment IlyasDevelopment added the ci:skip-changelog Add this label to skip changelog file check label Nov 14, 2024
@IlyasDevelopment IlyasDevelopment self-assigned this Nov 14, 2024
@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (6f9d6b0) to head (7e4771a).
Report is 76 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #129      +/-   ##
===========================================
+ Coverage    85.70%   90.42%   +4.71%     
===========================================
  Files          157      157              
  Lines         3560     3560              
  Branches       261      261              
===========================================
+ Hits          3051     3219     +168     
+ Misses         445      277     -168     
  Partials        64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IlyasDevelopment IlyasDevelopment marked this pull request as ready for review November 14, 2024 21:08
@IlyasDevelopment IlyasDevelopment merged commit 651f00c into develop Nov 15, 2024
@IlyasDevelopment IlyasDevelopment deleted the feature/DOP-21350 branch November 15, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants